search

sbugert / react-native-admob

A react-native component for Google AdMob banners
BSD 2-Clause "Simplified" License
1.13k stars 530 forks source link

Android AdMob 20.0.0 Support #572

Open hakanemrebasol opened 3 years ago

hakanemrebasol commented 3 years ago

We started to have various problems with the new version update of AdMob.

Since the project was not compiled, we were using version 19.7.0 manually.

Sometimes we cannot get successful, unsuccessful status in the 19.7.0 version. On the other hand, the project is not compiled due to deprecated/removed methods when we tried to use the new admob version.

Would be appreaciated if you have any suggestion to solve these problems. Thanks in advance

khurramwaqar commented 3 years ago

The same issue has with me.

pod 'Google-Mobile-Ads-SDK', '~> 8.5'

if you guys have any solution please help us.

Thanks

wjaykim commented 3 years ago

I started to work on new package https://www.npmjs.com/package/@react-native-admob/admob because this package seems to not maintained any more. My package supports new SDK and also support interstitial and rewarded with react hook.

mikehardy commented 2 years ago

the admob package that was @react-native-firebase/admob before Google removed admob APIs from Firebase has been peeled out to it's own package - https://github.com/invertase/react-native-google-mobile-ads - and supports v20 as well. @wjaykim not sure how you feel about collaborating (I totally understand if not - no worries!) but if you wanted to join forces on a single package maybe we could work something out? Either way, cheers :-)

wjaykim commented 2 years ago

@mikehardy I'd love to. Since I cannot afford to maintain @react-native-admob/admob continuously, I was considering contributing to react-native-google-mobile-ads instead of expanding my library.

mikehardy commented 2 years ago

That would be fantastic, we would love to collaborate! I guess the first step would be to see what the current feature set differences are, to see where we can improve the invertase package with any unique features your package has, then if it all seems good once all features are even maybe a migration guide ? We can add you as a maintainer (if you want, if course! ) Then there would be three of us contributing, which should help keep the package healthy without killing us as maintainers...

mikehardy commented 2 years ago

For anyone else watching here, https://github.com/invertase/react-native-google-mobile-ads just published v5 where we forward-ported to the new "UMP" SDK provided by Google for managing consent https://github.com/invertase/react-native-google-mobile-ads/pull/82

So as far as I know, we're 100% up to date with no deprecated SDKs in the module anymore and we're open and ready to collaborate with anyone. Cheers!