Update DateFormat.groovy

sburke781 / hubitat

Hubitat apps and device drivers

8 stars 8 forks source link

Update DateFormat.groovy #31

Closed luarmr closed 3 years ago

luarmr commented 3 years ago

Not sure if you accept prs, I see your post in the Hubitat Comunity and this code basically help me to understand Drivers. Thanks for share!!!

Added a new attribute that can be used in the dashboard. With the full information.
My editor automatically found some mixing tabs and spaces so I remove the tabs.
Group new Date() in one. The main reason is the incredibly unlikely possibility that the 2 Dates get a different day, month, or even year. And also saving one call to Date. :)

sburke781 commented 3 years ago

Happy to take suggestions, updates to my code, thanks for taking the time, glad you got some benefit out of it. I'll take a look at the code some time soon and merge it back to the master branch.

Simon

luarmr commented 3 years ago

@sburke781 I added another commit. The idea is to introduce timezones. I am working on a dashboard where I want to show different times. I didn't create a separate Pr to no overcomplicate the flow with conflicts. I understand that it may be a personal need. So If you decide not to complicate this component feel free to close this pull request and I will create a separate repository for my use.

And thanks again!

sburke781 commented 3 years ago

Nice work, just installed it on my hub and it works perfectly, just need to make sure people Save Preferences when they apply it, otherwise it throws errors on a refresh. Happy to merge the change.