search

sbuss / bitmerchant

Bitcoin merchant tools
MIT License
82 stars 36 forks source link

Parameter wallet_num is not used #58

Open ghtdak opened 8 years ago

ghtdak commented 8 years ago

Not sure if this matters

https://github.com/sbuss/bitmerchant/blob/master/tests/generate_bip32_test_vectors.py#L23

also seed in generate_address_vector

https://github.com/sbuss/bitmerchant/blob/master/tests/generate_bip32_test_vectors.py#L44

sbuss commented 8 years ago

Hi @ghtdak, thanks for the issue! This is definitely a mistake and makes the code hard to follow. I should have removed wallet_num from get_new_address in c2542110e58dcef61e4f1bf011109e9a7548bc18 since the random seed parameter takes care of it, but I overlooked it.

I'm preparing a fix now.