search

sbussetti / deluge-siphon

A Chrome extension for sending torrents to your Deluge server.
http://sbussetti.github.io/deluge-siphon/
82 stars 22 forks source link

Deluge Siphon CSS spilling over into unrelated page CSS and breaking #44

Closed nicholascowan closed 7 years ago

nicholascowan commented 7 years ago

When I use Sonarr the modal CSS is being overwritten by injected stylesheets within Deluge Siphon, I think the latest changes to the CSS where the parent selector was removed is causing undesirable effects.

Either way, I had to disable Deluge Siphon until this is resolved.

kolinger commented 7 years ago

I have same problem. Siphon injecting set of styles to .modal class. This will result in broken websites. Disabling deluge siphon fixes issue.

deluge-injected-styles

sbussetti commented 7 years ago

This should be fixed in 0.70.9 - can you verify?

~ Steve

On January 30, 2017 at 3:19:39 AM, Tomáš Kolinger (notifications@github.com) wrote:

I have same problem. Deluge injecting set of styles to .modal class. This will result in broken websites. Disabling deluge fixes issue.

[image: deluge-injected-styles] https://cloud.githubusercontent.com/assets/1590930/22416180/0f03bfb4-e6cd-11e6-90df-a2a05f391402.PNG

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/sbussetti/deluge-siphon/issues/44#issuecomment-276002358, or mute the thread https://github.com/notifications/unsubscribe-auth/AA3v0YUd8PIXyQPMuhNXWQNZfs_M6uJgks5rXZ0bgaJpZM4LxBpu .

bjammin commented 7 years ago

I also have this problem with the .modal class being injected and breaking various web sites.

Also happening in 0.70.9

sbussetti commented 7 years ago

Ugh -- somehow (by somehow I mean I made a mistake), the original jquery-modal css got into the package and not my modified copy that scopes all the selectors under a unique identifier.

I just pushed a new version with what I thought was in there all along. Sorry folks.

kolinger commented 7 years ago

Problem solved for me (0.71.0).

Thank you!

sbussetti commented 7 years ago

@kolinger thanks for reporting fixed status. Again apologies for the oversight. I did basically a total rewrite for 0.7x and I'm still getting things stabilized.

nicholascowan commented 7 years ago

@sbussetti @kolinger Thanks for quick resolution.

bjammin commented 7 years ago

Fixed for me in 0.71 too. Thanks for the quick response!