search

sbussetti / deluge-siphon

A Chrome extension for sending torrents to your Deluge server.
http://sbussetti.github.io/deluge-siphon/
82 stars 22 forks source link

Disabling control + right click macro does not remove the Deluge menu item #5

Closed gosuto-inzasheru closed 11 years ago

gosuto-inzasheru commented 11 years ago

Even after unchecking the "Enable control + right click macro" option, right clicking a link still gives me the "Send to deluge" menu item.

I would assume it would be disabled? If that is not what is meant to happen; why not?

Is there another way to remove this menu item without giving up on left click behaviour?

sbussetti commented 11 years ago

There's actually 3 ways to add torrents.

  1. left-click via settings regex (controlled by left-click settings option): left clicking adds the item if the link matches the regex
  2. control + right click: if you hold control while right clicking, it will add the item (controlled by the control+right click setting you are posting about)
  3. right click via context menu: the item is added via the context menu.

Item 3 has no setting to disable it -- I never really thought someone would want to use the extension but hide it from the context menu. I personally use the control + right-click method.

All that said, I'll make a patch to add a setting that lets you disable the context menu entry -- there is currently no way to disable that.

gosuto-inzasheru commented 11 years ago

Ah OK yeah I missed the distinction between the second and third variant.

Such a patch would be A-MA-ZING, thanks :-) On 23 Jun 2013 16:18, "Steve Bussetti" notifications@github.com wrote:

There's actually 3 ways to add torrents.

  1. left-click via settings regex (controlled by left-click settings option): left clicking adds the item if the link matches the regex
  2. control + right click: if you hold control while right clicking, it will add the item (controlled by the control+right click setting you are posting about)
  3. right click via context menu: the item is added via the context menu.

Item 3 has no setting to disable it -- I never really thought someone would want to use the extension but hide it from the context menu. I personally use the control + right-click method.

All that said, I'll make a patch to add a setting that lets you disable the context menu entry -- there is currently no way to disable that.

— Reply to this email directly or view it on GitHubhttps://github.com/sbussetti/deluge-siphon/issues/5#issuecomment-19874617 .

sbussetti commented 11 years ago

v0.65.9 adds the ability to turn the context menu on and off from the options page -- just pushed update to chrome store, so should be available in a couple hours.

gosuto-inzasheru commented 11 years ago

Thanks dude, does exactly what it says on the package!

gosuto-inzasheru commented 11 years ago

Thanks for this, do you accept Bitcoin donations? Couldn't find a professional website or other contact details...

sbussetti commented 11 years ago

Nope I do this for the love of the game. I'll look into adding a donate button though. Thank you very much for the support.