Fixed scaling issues for both Android and Ios fixes #95

sbycrosz / react-native-credit-card-input

Easy, cross-platform credit-card input for your React Native Project! Start accepting payment 💰 in your app today!

MIT License

1.47k stars 706 forks source link

Closed andidev closed 2 years ago

andidev commented 6 years ago

The translation should be applied before scaling to avoid cropping in Android and incorrect positions in both Android and Ios.

The width needs to be scaled for scaling > 1

This fixes all issues with scaling issues

@sbycrosz Thanks for a great component. Hope you will merge this, it's tested on both Ios and Android.

gianpaj commented 6 years ago

This should be merged by the way. I've tested on both Android and iOS and it works fine.

I had to pull the CardView.js from this PR and manually add it to project (incl. the images)

LRNZ09 commented 6 years ago

@sbycrosz seems gone.

ebellumat commented 5 years ago

Please, bring your pull requests to my repo. I Will maintain this lib.