search

sbycrosz / react-native-credit-card-input

Easy, cross-platform credit-card input for your React Native Project! Start accepting payment 💰 in your app today!
MIT License
1.46k stars 699 forks source link

add support for verve card #156

Closed nwaughachukwuma closed 2 months ago

nwaughachukwuma commented 4 years ago

Hey @sbycrosz, I had made a new card addition (Verve) which is a well-known card in Africa and had published it under another npm repository here. But I feel it's better to integrate it with this one and pull that one down. Please explore and see if the addition aligns with your design pattern. Thanks

ebellumat commented 4 years ago

Please, bring your pull requests to my repo. I Will maintain this lib.

https://github.com/ebellumat/react-native-credit-card-input

nwaughachukwuma commented 4 years ago

Alright cool. I'll do so ASAP

nwaughachukwuma commented 4 years ago

I tried do this, but I could not find your repo. Is there something am not doing?

ebellumat commented 4 years ago

I tried do this, but I could not find your repo. Is there something am not doing?

I don't know, can you try again? https://github.com/ebellumat/react-native-credit-card-input

nwaughachukwuma commented 4 years ago

Hi @ebellumat so I click on pull request on your repo and it takes me to @sbycrosz repo. See the link to the video below for what transpired:

https://photos.app.goo.gl/6NMCCRW6MKSzNemi9

https://photos.app.goo.gl/7NRCk96e9rvaTsQHA

ebellumat commented 4 years ago

Hi @ebellumat so I click on pull request on your repo and it takes me to @sbycrosz repo. See the link to the video below to for what transpired:

https://photos.app.goo.gl/6NMCCRW6MKSzNemi9

https://photos.app.goo.gl/7NRCk96e9rvaTsQHA

First, fork my repo, after that, open the PR. =)

nwaughachukwuma commented 4 years ago

Hi @ebellumat, new PR is sent of the fork of your Repo. Let's continue there, please