search

sc-arecrow / pe

0 stars 0 forks source link

Find command returns all logs when the keywords (or any substring of) "time", "reps", "calories", "comments" #3

Open sc-arecrow opened 3 years ago

sc-arecrow commented 3 years ago

Find command returns all logs when the keywords (or any substring of) "time", "reps", "calories", "comments"

This could be troublesome for a user who

  1. used these words, or any substring of these words, in their log comments
  2. want to filter their logs to those containing comments with these words

Steps to reproduce:

  1. Start FixMyAbs with the sample data
  2. Add a log with any of the words or their substring in the comments add e/pullups r/10 c/time
  3. Find logs that contain the "time" keyword find time

image.png

Expected behaviour:

  1. Only the new log added is displayed

Actual behaviour:

  1. All logs are displayed

image.png

Logs circled in red should not be displayed.

nus-pe-bot commented 3 years ago

Team's Response

We intended for the user to be specific in the search with regards to what is seen in the Logbook.

If the user wants to search for time, he/she can easily type 'Time: Fri', instead of just 'Fri', which may be the name of an exercise.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: I agree that the user is able to modify their search parameters to filter the logs that they want.

However, the intention of the team of developers does not change the fact that this is a potential gotcha for users.

In order to mitigate this feature flaw, perhaps a note could be added under the find command in the User Guide to warn users of this gotcha.

:question: Issue type

Team chose [type.FeatureFlaw] Originally [type.FunctionalityBug]

Reason for disagreement: [replace this with your explanation]