sc-arecrow / pe

0 stars 0 forks source link

Inconsistency in add and find features #5

Open sc-arecrow opened 4 years ago

sc-arecrow commented 4 years ago

The add log feature allows you to specify the exercise name which is case-insensitive and whitespace-insensitive.

However the find log feature is whitespace sensitive which is somewhat inconsistent.

Users may be confused when they are able to add a new log with whitespace insensitivity but not do the same with finding their logs.

Steps to reproduce:

  1. Start FixMyAbs with sample data
  2. Add a new log for pull ups exercise, using whitespace insensitivity add e/pullups r/10 c/
  3. Find all pull up logs find pullups

Expected behaviour:

  1. Both pull up logs are displayed

image.png

Actual behaviour:

  1. Both pull up logs are not displayed

image.png

image.png

nus-pe-bot commented 3 years ago

Team's Response

We want users to find by other parameters as well, not only by name. It will be more accurate if it is whitespace sensitive, or else it will not be intuitive to the user.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: I argue that it is more intuitive for the user to expect commands with similar parameters (here, it is the name of the exercise) to work the same way. Granted, if the User Guide had stated that the find command is whitespace-sensitive, then this confusion would not occur. However, this was omitted from the User Guide.

image.png