Closed cgewecke closed 7 months ago
Attention: 3 lines
in your changes are missing coverage. Please review.
Comparison is base (
d3a5b37
) 95.92% compared to head (62408ea
) 95.77%.
Files | Patch % | Lines |
---|---|---|
lib/collector.js | 88.88% | 2 Missing :warning: |
plugins/resources/nomiclabs.utils.js | 90.00% | 1 Missing :warning: |
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
E2E tested against 1inch solidity-utils and got the output below. Compare with / identical to: https://github.com/1inch/solidity-utils/actions/runs/7756078740/job/21152695486
NB: there was a failing test that looked at gas specific values - to be expected because the instrumentation mechanism changed and there's some consumption variance.
PUBLISHED at the viaIR tag
853, #848, #790, #715, #417
Uses solidity built-in ignored by the yul optimizer to preserve instrumentation when
viaIR
is set to true. This should address all the insane optimizer config problems.Coverage in the plugin's own tests is missing for an edge case where the optimizer has:
... we hit the first two conditions in the integration tests but the hash is a duplicate.
TODO
e2e test on Zeppelin with viaIR flag set to true and verify coverage is identicalAdd tests for file-level function declarations (weirdly missing)