search

sc-forks / solidity-coverage

Code coverage for Solidity smart-contracts
MIT License
979 stars 264 forks source link

Verify skipFiles works as expected when using hardhat-foundry #867

Closed cgewecke closed 9 months ago

cgewecke commented 9 months ago

See hardhat issues comment

cgewecke commented 9 months ago

@bingen Pinging you over at solidity-coverage #867.

I haven't been able to reproduce any problems with the skipFiles option when foundry.toml is present (in 0.8.8) - e.g skipping seems to work.

Have you run npx hardhat clean since updating the package?

If that doesn't resolve can you link to the repo where. you're seeing this (or post your .solcover.js, or something to debug this with) ?

bingen commented 9 months ago

Ohh, my config file was named solcover.js instead of .solcover.js. Now it works. Sorry about that!!

cgewecke commented 9 months ago

Oh good, no worries!