search

sc-forks / solidity-coverage

Code coverage for Solidity smart-contracts
MIT License
975 stars 263 forks source link

Check all PUSH opcodes for instr. hashes when viaIR is true #871

Closed cgewecke closed 7 months ago

cgewecke commented 7 months ago

See #870 - it looked like instrumentation was getting stripped out by viaIR, but actually some hashes are being displaced onto higher PUSHn opcodes that the collector isn't tracking.

(There's still an unhit line in #870 however ... waiting on answer to this https://github.com/sc-forks/solidity-coverage/issues/870#issuecomment-1968232584)

codecov-commenter commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.50%. Comparing base (32029b4) to head (b2e9859).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #871 +/- ## ========================================== + Coverage 96.47% 96.50% +0.02% ========================================== Files 19 19 Lines 1021 1029 +8 ========================================== + Hits 985 993 +8 Misses 36 36 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.