search

sc0ttkclark / wordpress-fields-api

The 2024 Fields API proposal for WordPress Core
https://make.wordpress.org/core/tag/fields-api/
361 stars 42 forks source link

Run core phpunit / qunit tests, ensure they are passing with our implementations #20

Closed sc0ttkclark closed 1 year ago

sc0ttkclark commented 9 years ago
Idealien commented 8 years ago

Two failures:

1) test_available_item_types

Failed asserting that two arrays are equal.
 /srv/www/wordpress-develop/src/wp-content/plugins/wordpress-fields-api/tests/core/nav-menus.php:440
Differences relate to expected being singular titles (Post, Page, Category) and actual is plural (Posts, Page, Categories)

2) test_available_items_template

Failed asserting template [codeblock] matches PCRE pattern
/srv/www/wordpress-develop/src/wp-content/plugins/wordpress-fields-api/tests/core/nav-menus.php:511
"#<h4 class="accordion-section-title".*>\s*Category#".
sc0ttkclark commented 8 years ago

These are related to unsynced changes between WP 4.4 and our Customizer tests/implementation. I haven't synced since WP 4.3 stable was released.

We forked the core unit tests to be able to test our customizer implementation, so they’re not actually failing because of something that broke in Fields API. We'll just have to update our implementation if we want 4.4 compatibility too.