search

sc0v / binder

The Spring Carnival managment application built for Carnegie Mellon Spring Carnival.
16 stars 19 forks source link

Shift Test - CI Fail #235

Closed ghost closed 7 years ago

ghost commented 7 years ago

Need to fix shift test, so that it doesn't fail the CI test. Works locally but consistently off by the same time when running it through CI

screen shot 2017-03-04 at 5 14 17 pm
sclark commented 7 years ago

Is there still a branch where this test is failing on the CI server?

brucethesloth commented 7 years ago

I don't think so since we commented out the test. If you want to reproduce the error, you can always go to the unit test class for shift and re-comment the last test function.

pkoenig10 commented 7 years ago

@blinblinblin can you guys fix the test before merging into master? Commenting out tests because they break the CI sort of defeats the purpose of having tests

ghost commented 7 years ago

@pkoenig10 Yeah we will. We commented/opened a issue to remind ourselves because it's a very small error with server times but runs fine locally. We wanted to focus in on our scope and return to it after notification feature has been created.

sclark commented 7 years ago

This test now passes on the CI server, so I am closing the issue.