search

sc0v / binder

The Spring Carnival managment application built for Carnegie Mellon Spring Carnival.
16 stars 19 forks source link

Don't rely on specific shift_type IDs for shift scoping. #275

Closed timparenti closed 6 years ago

timparenti commented 6 years ago

The new seed files for 2018 populate the shift types in a different order, so match by name instead. This can almost definitely be made more elegant.

e.g., https://binder.springcarnival.org/shifts?type=watch currently shows the Coordinator Shifts instead of the Watch Shifts since they are the ones with shift_type_id = 1.

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 14.098% when pulling 99f40110f5325e62151a9c675339d540f26920c0 on timparenti:shift-scope-fix into 2d726aa1e97bee8f4353230ab9d73fa18c6849dd on sc0v:booth-chair-add-members.

timparenti commented 6 years ago

Rebased onto current production.