search

sc12070 / react-native-drag-sort-gridview

A draggable and sortable grid view for react native
22 stars 8 forks source link

Custom item width, custom list width, onLongPress item, onRemove item #1

Closed buuhvprojects closed 1 year ago

buuhvprojects commented 1 year ago

feat: Custom Item Width and Custom List Width feat: onLongPress in view item to enable edit mode feat: Remove Option

sc12070 commented 1 year ago

Hi buuhvprojects,

Thank you for your contribution.

About item width, it is currently controlled by listWidth and numColumns. Adding itemWidth would violate that property.

For long press and remove item, I think it is a really good idea to pre-implement those feature in this lib but on the other hand, I want to leave a room for other developers to decide there flow. Actually I use long press to trigger edit mode in my other project https://github.com/sc12070/member-collection. However, other developer may want to have a separate button to trigger edit mode and leave long press for other operation. That's why this lib receive isEditing as a props in order to make this lib to be extendable.

I am really appreciate to your changes, but at this moment, those change might not very suitable for this lib.