search

scVENUS / PeekabooAV-Installer

This repository provides scripts and configuration files to install, update and test a Peekaboo installation
GNU General Public License v3.0
7 stars 9 forks source link

Release tarball does not include PeekabooAV submodule content #36

Closed michaelweiser closed 5 years ago

michaelweiser commented 5 years ago

The tarballs auto-generated by GitHub do not contain submodule content. Since they're not git repos either, git submodule commands can not be used either. We need to get the submodule content into the tarball.

michaelweiser commented 5 years ago

There seems no easy way to do this with only GitHub mechanics. A plethora of other projects have run into this as well. They eventually all switched to attaching custom-built tarballs to releases that include the submodules.

Perhaps we should consider going back to installing releases from PyPI and only optionally go looking for a manually provided PeekabooAV subdirectory for testing inbetween releases? What's your take on this, @Jack28?

michaelweiser commented 5 years ago

Just rediscovered a (seemingly? :) clever idea I had on this earlier: https://github.com/scVENUS/PeekabooAV-Installer/issues/9#issuecomment-418710531.

Jack28 commented 5 years ago

Agreed. To look for the subdirectory instead of the branch is more visible and less likely to go wrong though.

michaelweiser commented 5 years ago

Agreed. Will come up with apropriate detection of the directory in the ansible playbook and otherwise revert to PyPI.

Jack28 commented 5 years ago

NOTE: pstrap.sh doesn't include --recurse-submodules