search

scVENUS / PeekabooAV-Installer

This repository provides scripts and configuration files to install, update and test a Peekaboo installation
GNU General Public License v3.0
7 stars 9 forks source link

Non submodule delivery #41

Closed michaelweiser closed 5 years ago

michaelweiser commented 5 years ago

Move away from pulling the Peekaboo source in as a submodule since that presented a number of pratical problems. Instead, install from PyPI or optionally a subdirectory manually provided by a developer for testing a non-release version. In both cases, we rely on updated install logic in the Peekaboo source distribution to provide a number of files in a documentation subdirectory of the installation prefix so we need not duplicate files we previously grabbed directly from the source directory in the installer.

Jack28 commented 5 years ago

Fails as expected because pip installs 1.7 and doesn't know about: https://github.com/scVENUS/PeekabooAV/pull/85

When manually installed to venv (and patched out of playbook) installs everything perfectly. Also nicely respects a placed repository and installs the code there.

LGTM thx

Jack28 commented 5 years ago

This should be approved, rather than closed, sorry

michaelweiser commented 5 years ago

Sorry, forgot to mention that PyPI interaction can be tested with non-released versions using devpi (https://pypi.org/project/devpi/). With that you create a local caching PyPI proxy where you can overlay a non-released Peekaboo source distribution for testing of all the PyPI interaction. Added some doc to scVENUS/PeekabooAV#85.