search

scVENUS / PeekabooAV-Installer

This repository provides scripts and configuration files to install, update and test a Peekaboo installation
GNU General Public License v3.0
7 stars 9 forks source link

Remove duplicate of amavis plugin #8

Closed michaelweiser closed 5 years ago

michaelweiser commented 6 years ago

Currently we have a copy of the amavis plugin in the installer that needs to be kept in sync with the main instance in PeekabooAV repo. We should eliminate the local copy and take the plugin directly from the Peekaboo installation.

michaelweiser commented 6 years ago

9 is a prerequite for this because we otherwise loose the ability to test unreleased versions of the plugin with the installer.

michaelweiser commented 6 years ago

I have some (stale) code for this here https://github.com/michaelweiser/PeekabooAV-Installer/commit/aa44c4651fa0297d10f8683baf38e90036e1f160.

Jack28 commented 6 years ago

We can not rely on those files beeing at that location. I'd rather have the PeekabooAV repository as a submodule of the Installer repository. Not sure if a submodule can be checked out to a specific tag/release (branch is possible).

SebastianDeiss commented 6 years ago

I seems a lot more simple to me to ship the AMaViSd plugin with the PIP package and then copy it to /etc/amavis/conf.d, rather than using a git submodule.

michaelweiser commented 6 years ago

I concur: For released Peekaboo versions we should use the plugin from the distribution. If we discover an error in it, we obviously make a new release of Peekaboo and update the installer to install that new release. The case of developing the installer and testing it with unreleased versions of the plugin in preparation for the next peekaboo release is covered #9.

michaelweiser commented 6 years ago

We can not rely on those files beeing at that location.

Why's that? Doesn't the installer direct pip to install it there? If not, can the installer do so so we can rely on the location? IMO that would be an acceptable tradeoff to get a reproducible installation in any case.

Otherwise: Can ansible interview pip for the location it installed the peekaboo package to so it knows where to look for the plugin?