search

scVENUS / PeekabooAV

Peekaboo Extended Email Attachment Behavior Observation Owl
https://peekabooav.de
GNU General Public License v3.0
66 stars 20 forks source link

Pid file 2 #200

Closed michaelweiser closed 2 years ago

michaelweiser commented 2 years ago

Revisiting PID files (sorry), I propose to change the default to not creating a PID file at all. It's plain redundant for systemd and (most) containers and would require explicitly deconfiguring PID file creation by setting the option in peekaboo.conf to empty, which is hard to read and spot and can cause confusion. With these changes it can still be switched on by setting the option, if required. Consequently we remove the PIDFile option from our systemd unit because I strongly suspect it was ignored the whole time anyway (my tests confirm it).

~note2self: Once the UNIX domain socket is gone as well (#194), the RuntimeDirectoy can go as well. Should be added to whatever is merged last.~

michaelweiser commented 2 years ago

Rebased to current master with conflicts resolved. No changes.

michaelweiser commented 2 years ago

IMO this is ready for merge now. systemd unit cleaned up further. Tested with vagrant with both 18.04 and 20.04.