Auto Zoom for Rand256

[sca075]

This PR is to get the auto zoom function working on Rand256. There are still issues with the active zones mapping that will be addressed with the next commits. For instance the image zoom now do not crash the camera. So we are at 50% of completion.

• [x] Refactor rrparser.py, this data conversion module was made on the base of a java script. Did attempt to make it a little more python style, for readability and in order to later maintain it easier.
• [x] The image auto crop re-trim for zoom corners swap (rotated) as the min / max values to trim the np array need to be order. Made so that the values are always sorted in the correct order. This fix the image render issues faced during tests. At current the image actually zoom (resize) correctly.
• [x] Fixing the active zones, Rand256 do not provide this information, so the computation of this list for the active zones need to be perform in the Camera. We do get the command segment clean and by using the data in the command we might turn on the bool value active for the segment. This is okay. The issue is in the index of the list that do not match.
• [x] Removing debug lines and polishing the code.
• [x] Retest on all 3 available environments.

Summary by CodeRabbit

• New Features

  • Updated the version number for the mqtt_vacuum_camera component to reflect minor enhancements and bug fixes.
  • Improved image cropping logic for more precise dimensions.
  • Enhanced room coordinate calculations for better accuracy in image data handling.
  • Streamlined data retrieval process for room segments, boosting performance.
  • Refined robot position handling and zoom functionality for improved stability.

• Bug Fixes

  • Removed redundant logging statements to enhance performance and streamline output.

• Refactor

  • Introduced structured classes for constants and types in the RRMapParser, improving code organization and readability.

[coderabbitai[bot]]

Walkthrough

The update to the mqtt_vacuum_camera component includes a minor version increment from 2024.08.1 to 2024.08.2. Changes span multiple files and primarily involve enhancements to image processing logic, room data handling, and overall code organization. Notable improvements include refined cropping calculations, streamlined room data access, and updates to the RRMapParser class for better maintainability and readability.

Changes

File Path	Change Summary
custom_components/mqtt_vacuum_camera/manifest.json	Version updated from 2024.08.1 to 2024.08.2.
custom_components/mqtt_vacuum_camera/utils/auto_crop.py	Removed redundant comments; improved crop dimension calculations with rounding and sorting.
custom_components/mqtt_vacuum_camera/utils/img_data.py	Adjusted async_get_rooms_coordinates for accuracy; removed commented-out code.
custom_components/mqtt_vacuum_camera/valetudo/MQTT/connector.py	Removed dependency on RoomStore for room data; improved efficiency in rrm_handle_active_segments.
custom_components/mqtt_vacuum_camera/valetudo/rand256/image_handler.py	Modified room indexing logic; removed commented-out auto-zoom code for clarity.
custom_components/mqtt_vacuum_camera/valetudo/rand256/reimg_draw.py	Removed logging statements in _draw_segments; version updated from 2024.08.1 to 2024.08.2.
custom_components/mqtt_vacuum_camera/valetudo/rand256/rrparser.py	Refactored RRMapParser; introduced structured classes for constants; updated method signatures with type hints.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.

[sca075]

@coderabbitai full review

[coderabbitai[bot]]

Actions performed

Full review triggered.