search

sca075 / mqtt_vacuum_camera

Camera Integration for Home Assistant to export and render all Vacuums connected via MQTT( including Valetudo Hypfer and RE(rand256)) Maps.
Apache License 2.0
101 stars 5 forks source link

Current room detection doesn't work well with non-rectangular rooms #261

Open andrey-yantsen opened 1 day ago

andrey-yantsen commented 1 day ago

Checklist

The problem

Firstly, thank you for the integration! It saved me a lot of time after I started using Valetudo.

I'm not sure if it's really a bug-report, or more of a feature request, but anyway. I have seven rooms on the map, defined as per screenshot below. When the robot is in the room 2, the integration reports it as being in the room 1. And room 4 is often being reported as room 3 (and sometimes 6).

Would it be possible to improve room detection for such cases?

image

What version of an integration has described problem?

v2024.10.0

What was the last working version of an integration?

No response

What vacuum model do you have problems with?

Roborock S7

Please firmware installed on your Vacuum.

No response

What type of platform you use?

VEMLinux (Virtual Machine) such as Proxmox, VMWare, etc.

What version of Home Assistant do you use?

2024.10.3

What type of installation are you running?

Home Assistant OS

Logs or Errors shown in the HA snapshots (please enable the Debug Mode) text will be auto formatted to code.

No response

Function, that in your opinion is creating the issue.

Not sure / none of the above.

Additional information

No response

sca075 commented 1 day ago

@andrey-yantsen thanks for your report, I will check it soon, at the moment I'm working on other items for the next release but surely will do my best to fix this. I understand that the in_room variable is not updated correctly from your report. Probably within the next beta or the final release of 2024.11.0 this will work again correctly 😉

Sorry for the inconvenience anyway. Thanks for your feedback.