search

sca075 / mqtt_vacuum_camera

Camera Integration for Home Assistant to export and render all Vacuums connected via MQTT( including Valetudo Hypfer and RE(rand256)) Maps.
Apache License 2.0
104 stars 6 forks source link

Issue with _handle_coordinator_update on 2024.10.0 #263

Open Minims opened 2 weeks ago

Minims commented 2 weeks ago

Checklist

The problem

Since 2024.10.0 i have this error in HA logs. I have reinstalled 2024.9.0, all is OK.

WARNING (MainThread) [py.warnings] /usr/src/homeassistant/homeassistant/helpers/update_coordinator.py:168: RuntimeWarning: coroutine 'VacuumSensor._handle_coordinator_update' was never awaited
  update_callback()

What version of an integration has described problem?

2024.10.0

What was the last working version of an integration?

2024.9.0

What vacuum model do you have problems with?

Roborock S5

Please firmware installed on your Vacuum.

No response

What type of platform you use?

ARM (Raspberry Pi, Odroid, etc.) > 4GB

What version of Home Assistant do you use?

2024.10.4

What type of installation are you running?

Home Assistant Supervised

Logs or Errors shown in the HA snapshots (please enable the Debug Mode) text will be auto formatted to code.

WARNING (MainThread) [py.warnings] /usr/src/homeassistant/homeassistant/helpers/update_coordinator.py:168: RuntimeWarning: coroutine 'VacuumSensor._handle_coordinator_update' was never awaited
  update_callback()


### Function, that in your opinion is creating the issue.

None

### Additional information

_No response_
sca075 commented 2 weeks ago

@Minims thanks for the report I will check it out and in the next version that I will release should be fixed.

sca075 commented 2 weeks ago

@Minims I think the issue you reported should be already fix on the beta 0 2024.11.0b0 pre release. Would you be so kind to confirm?

Minims commented 2 weeks ago

@sca075 I have the exact same error with 2024.11.0b0

sca075 commented 2 weeks ago

@sca075 I have the exact same error with 2024.11.0b0

@Minims I'm testing the versions above and I couldn't replicate the phenomenon that by the way look coming from HA. Of course the error is due to the sensors that are automatically generated for Rand256. I will check better in the next days also because I think to know from where it comes from.

Minims commented 2 weeks ago

Does the Lovelace card make this call ?

sca075 commented 1 week ago

@Minims The point is this the sensor for the vacuum are created by the coordinator entity and somehow I understand there is some issue with the init of the sensors, I repeat on my test environment if I remember well this issue happened only once an then somehow, at the moment looks solved from the current implementation. What I can do is to test it on a different test environment and try to reproduce the the first init of the sensors. Or I can add a flag to enable / disable those when the camera entity is created (config wise). I know that there is probably an issue with the startup of the coordinator.. I'm trying to understand this and would really help if you have some additional logs. Can you please let me know if the sensors entities are created and somehow is there some value? Also can you please enable the debug level of the integration and provide me the full log?

Minims commented 1 week ago

@sca075

version 2024.11.0b0

Here is sensors i have :

vaccum

vaccum2

and debug logs 

2024-10-31 17:00:22.891 DEBUG (MainThread) [custom_components.mqtt_vacuum_camera.coordinator] Finished fetching mqtt vacuum camera data in 0.000 seconds (success: True)
2024-10-31 17:00:23.550 DEBUG (MainThread) [custom_components.mqtt_vacuum_camera.sensor] duration in second 79.3 converted to 0:01:19.300000
2024-10-31 17:00:23.550 DEBUG (MainThread) [custom_components.mqtt_vacuum_camera.sensor] duration in second 827.4 converted to 0:13:47.400000
2024-10-31 17:00:23.550 DEBUG (MainThread) [custom_components.mqtt_vacuum_camera.sensor] duration in second 4758 converted to 1:19:18
2024-10-31 17:00:24.949 DEBUG (MainThread) [custom_components.mqtt_vacuum_camera] Platforms to unload: [<Platform.CAMERA: 'camera'>, <Platform.SENSOR: 'sensor'>]
2024-10-31 17:00:24.949 DEBUG (MainThread) [custom_components.mqtt_vacuum_camera.valetudo.MQTT.connector] Unsubscribing topics!!!
2024-10-31 17:00:24.952 DEBUG (MainThread) [custom_components.mqtt_vacuum_camera.coordinator] Camera roborock_s5 Starting up..
2024-10-31 17:00:24.952 INFO (MainThread) [custom_components.mqtt_vacuum_camera.camera] System Release: homeassistant, 6.6.58-v8-16k+
2024-10-31 17:00:24.952 INFO (MainThread) [custom_components.mqtt_vacuum_camera.camera] System Version: #1809 SMP PREEMPT Wed Oct 23 11:55:28 BST 2024
2024-10-31 17:00:24.952 INFO (MainThread) [custom_components.mqtt_vacuum_camera.camera] System Machine: aarch64
2024-10-31 17:00:24.952 INFO (MainThread) [custom_components.mqtt_vacuum_camera.camera] Python Version: 3.12.4
2024-10-31 17:00:24.960 INFO (MainThread) [custom_components.mqtt_vacuum_camera.camera] Memory Available: 4756.7 and In Use: 3101.8
2024-10-31 17:00:25.064 INFO (MainThread) [custom_components.mqtt_vacuum_camera.valetudo.MQTT.connector] Received Rand256 roborock_s5 image data from MQTT
2024-10-31 17:00:27.730 DEBUG (MainThread) [custom_components.mqtt_vacuum_camera.coordinator] Finished fetching mqtt vacuum camera data in 0.000 seconds (success: True)
2024-10-31 17:00:27.971 DEBUG (MainThread) [custom_components.mqtt_vacuum_camera.valetudo.MQTT.connector] roborock_s5: Processing Rand256 data from MQTT.
2024-10-31 17:00:27.972 DEBUG (MainThread) [custom_components.mqtt_vacuum_camera.sensor] duration in second 79.3 converted to 0:01:19.300000
2024-10-31 17:00:27.972 DEBUG (MainThread) [custom_components.mqtt_vacuum_camera.sensor] duration in second 827.4 converted to 0:13:47.400000
2024-10-31 17:00:27.973 DEBUG (MainThread) [custom_components.mqtt_vacuum_camera.sensor] duration in second 4758 converted to 1:19:18
2024-10-31 17:00:28.754 INFO (MainThread) [custom_components.mqtt_vacuum_camera.valetudo.MQTT.connector] roborock_s5: Extraction of Rand256 JSON Complete.
2024-10-31 17:00:28.756 INFO (roborock_s5_camera_0) [custom_components.mqtt_vacuum_camera.valetudo.rand256.image_handler] roborock_s5: Composing the image for the camera.
2024-10-31 17:00:28.756 INFO (roborock_s5_camera_0) [custom_components.mqtt_vacuum_camera.valetudo.rand256.image_handler] Vacuum Data ID: 7e63bf50-7249-480b-b49e-1380273083fe
2024-10-31 17:00:28.756 DEBUG (roborock_s5_camera_0) [custom_components.mqtt_vacuum_camera.valetudo.rand256.reimg_draw] robot position: [2580, 2562], robot angle: 100
2024-10-31 17:00:28.756 INFO (roborock_s5_camera_0) [custom_components.mqtt_vacuum_camera.valetudo.rand256.reimg_draw] roborock_s5: Empty image with background color
2024-10-31 17:00:28.981 INFO (roborock_s5_camera_0) [custom_components.mqtt_vacuum_camera.valetudo.rand256.reimg_draw] roborock_s5: Overlapping Layers
2024-10-31 17:00:29.029 INFO (roborock_s5_camera_0) [custom_components.mqtt_vacuum_camera.valetudo.rand256.reimg_draw] roborock_s5: Drawing segments.
2024-10-31 17:00:29.108 INFO (roborock_s5_camera_0) [custom_components.mqtt_vacuum_camera.valetudo.rand256.image_handler] roborock_s5: Completed base Layers
2024-10-31 17:00:29.108 DEBUG (roborock_s5_camera_0) [custom_components.mqtt_vacuum_camera.valetudo.rand256.image_handler] Checking for rooms data..
2024-10-31 17:00:29.108 DEBUG (roborock_s5_camera_0) [custom_components.mqtt_vacuum_camera.valetudo.rand256.image_handler] Rooms, data extracted!
2024-10-31 17:00:29.108 DEBUG (roborock_s5_camera_0) [custom_components.mqtt_vacuum_camera.valetudo.rand256.image_handler] Got Rooms Attributes.
2024-10-31 17:00:29.108 DEBUG (roborock_s5_camera_0) [custom_components.mqtt_vacuum_camera.valetudo.rand256.image_handler] roborock_s5 changed room.. searching..
2024-10-31 17:00:29.108 DEBUG (roborock_s5_camera_0) [custom_components.mqtt_vacuum_camera.valetudo.rand256.image_handler] roborock_s5 is in #1
2024-10-31 17:00:29.244 DEBUG (roborock_s5_camera_0) [custom_components.mqtt_vacuum_camera.valetudo.rand256.image_handler] roborock_s5: Frame number 1
2024-10-31 17:00:29.244 DEBUG (roborock_s5_camera_0) [custom_components.mqtt_vacuum_camera.valetudo.rand256.reimg_draw] charger position: [2595, 2557]
2024-10-31 17:00:29.244 INFO (roborock_s5_camera_0) [custom_components.mqtt_vacuum_camera.valetudo.rand256.reimg_draw] roborock_s5: Got zones.
2024-10-31 17:00:29.244 INFO (roborock_s5_camera_0) [custom_components.mqtt_vacuum_camera.valetudo.rand256.reimg_draw] roborock_s5: Got virtual walls.
2024-10-31 17:00:30.724 DEBUG (MainThread) [custom_components.mqtt_vacuum_camera.coordinator] Finished fetching mqtt vacuum camera data in 0.000 seconds (success: True)
2024-10-31 17:00:31.000 WARNING (MainThread) [homeassistant.components.camera] Updating mqtt_vacuum_camera camera took longer than the scheduled update interval 0:00:03
2024-10-31 17:00:31.001 DEBUG (MainThread) [custom_components.mqtt_vacuum_camera.sensor] duration in second 79.3 converted to 0:01:19.300000
2024-10-31 17:00:31.001 DEBUG (MainThread) [custom_components.mqtt_vacuum_camera.sensor] duration in second 827.4 converted to 0:13:47.400000
2024-10-31 17:00:31.001 DEBUG (MainThread) [custom_components.mqtt_vacuum_camera.sensor] duration in second 4758 converted to 1:19:18
2024-10-31 17:00:31.085 DEBUG (roborock_s5_camera_0) [custom_components.mqtt_vacuum_camera.valetudo.rand256.image_handler] roborock_s5: Auto cropping the image with rotation 0
2024-10-31 17:00:31.086 DEBUG (roborock_s5_camera_0) [custom_components.mqtt_vacuum_camera.utils.auto_crop] roborock_s5: Auto Trim Box data: [905, 2070, 2929, 3709]
2024-10-31 17:00:31.086 DEBUG (roborock_s5_camera_0) [custom_components.mqtt_vacuum_camera.utils.auto_crop] roborock_s5: Auto Trimmed image size: [2024, 1639]
2024-10-31 17:00:31.216 DEBUG (roborock_s5_camera_0) [custom_components.mqtt_vacuum_camera.valetudo.rand256.image_handler] roborock_s5: Frame Completed.
2024-10-31 17:00:31.216 DEBUG (roborock_s5_camera_0) [custom_components.mqtt_vacuum_camera.camera_processing]
roborock_s5: State attributes rooms updated
2024-10-31 17:00:31.217 INFO (roborock_s5_camera_0) [custom_components.mqtt_vacuum_camera.valetudo.rand256.image_handler] roborock_s5: Getting Calibrations points [905, 2070, 2929, 3709]
2024-10-31 17:00:31.217 INFO (roborock_s5_camera_0) [custom_components.mqtt_vacuum_camera.camera_processing]
Suspended the camera data processing for: roborock_s5.
2024-10-31 17:00:31.221 DEBUG (MainThread) [custom_components.mqtt_vacuum_camera.camera_processing]
roborock_s5: Camera frame processed.
2024-10-31 17:00:31.222 DEBUG (roborock_s5_camera_0) [custom_components.mqtt_vacuum_camera.camera] roborock_s5: Image from Json: 7e63bf50-7249-480b-b49e-1380273083fe.
2024-10-31 17:00:31.429 INFO (roborock_s5_snapshot_0) [custom_components.mqtt_vacuum_camera.snapshots.snapshot] Writing roborock_s5 users languages data.
2024-10-31 17:00:31.430 INFO (roborock_s5_snapshot_0) [custom_components.mqtt_vacuum_camera.utils.files_operations] UserLanguageStore is already initialized.
2024-10-31 17:00:31.625 DEBUG (MainThread) [custom_components.mqtt_vacuum_camera.camera] roborock_s5: Image update complete
2024-10-31 17:00:31.627 DEBUG (MainThread) [custom_components.mqtt_vacuum_camera.camera] roborock_s5 Camera Memory usage in GB: 1.15, 14.62% of Total.
2024-10-31 17:00:33.715 DEBUG (MainThread) [custom_components.mqtt_vacuum_camera.coordinator] Finished fetching mqtt vacuum camera data in 0.000 seconds (success: True)
2024-10-31 17:00:33.715 WARNING (MainThread) [py.warnings] /usr/src/homeassistant/homeassistant/helpers/update_coordinator.py:168: RuntimeWarning: coroutine 'VacuumSensor._handle_coordinator_update' was never awaited
  update_callback()

2024-10-31 17:00:34.003 DEBUG (MainThread) [custom_components.mqtt_vacuum_camera.sensor] duration in second 79.3 converted to 0:01:19.300000
2024-10-31 17:00:34.003 DEBUG (MainThread) [custom_components.mqtt_vacuum_camera.sensor] duration in second 827.4 converted to 0:13:47.400000
2024-10-31 17:00:34.003 DEBUG (MainThread) [custom_components.mqtt_vacuum_camera.sensor] duration in second 4758 converted to 1:19:18
2024-10-31 17:00:36.715 DEBUG (MainThread) [custom_components.mqtt_vacuum_camera.coordinator] Finished fetching mqtt vacuum camera data in 0.000 seconds (success: True)
2024-10-31 17:00:37.004 DEBUG (MainThread) [custom_components.mqtt_vacuum_camera.sensor] duration in second 79.3 converted to 0:01:19.300000
2024-10-31 17:00:37.004 DEBUG (MainThread) [custom_components.mqtt_vacuum_camera.sensor] duration in second 827.4 converted to 0:13:47.400000
2024-10-31 17:00:37.004 DEBUG (MainThread) [custom_components.mqtt_vacuum_camera.sensor] duration in second 4758 converted to 1:19:18
2024-10-31 17:00:39.715 DEBUG (MainThread) [custom_components.mqtt_vacuum_camera.coordinator] Finished fetching mqtt vacuum camera data in 0.000 seconds (success: True)
2024-10-31 17:00:40.004 DEBUG (MainThread) [custom_components.mqtt_vacuum_camera.sensor] duration in second 79.3 converted to 0:01:19.300000
2024-10-31 17:00:40.005 DEBUG (MainThread) [custom_components.mqtt_vacuum_camera.sensor] duration in second 827.4 converted to 0:13:47.400000
2024-10-31 17:00:40.005 DEBUG (MainThread) [custom_components.mqtt_vacuum_camera.sensor] duration in second 4758 converted to 1:19:18
2024-10-31 17:00:42.714 DEBUG (MainThread) [custom_components.mqtt_vacuum_camera.coordinator] Finished fetching mqtt vacuum camera data in 0.000 seconds (success: True)
2024-10-31 17:00:43.005 DEBUG (MainThread) [custom_components.mqtt_vacuum_camera.sensor] duration in second 79.3 converted to 0:01:19.300000
2024-10-31 17:00:43.006 DEBUG (MainThread) [custom_components.mqtt_vacuum_camera.sensor] duration in second 827.4 converted to 0:13:47.400000
2024-10-31 17:00:43.006 DEBUG (MainThread) [custom_components.mqtt_vacuum_camera.sensor] duration in second 4758 converted to 1:19:18
2024-10-31 17:00:45.715 DEBUG (MainThread) [custom_components.mqtt_vacuum_camera.coordinator] Finished fetching mqtt vacuum camera data in 0.000 seconds (success: True)
2024-10-31 17:00:46.005 DEBUG (MainThread) [custom_components.mqtt_vacuum_camera.sensor] duration in second 79.3 converted to 0:01:19.300000
2024-10-31 17:00:46.006 DEBUG (MainThread) [custom_components.mqtt_vacuum_camera.sensor] duration in second 827.4 converted to 0:13:47.400000
2024-10-31 17:00:46.006 DEBUG (MainThread) [custom_components.mqtt_vacuum_camera.sensor] duration in second 4758 converted to 1:19:18
2024-10-31 17:00:48.715 DEBUG (MainThread) [custom_components.mqtt_vacuum_camera.coordinator] Finished fetching mqtt vacuum camera data in 0.000 seconds (success: True)
2024-10-31 17:00:49.006 DEBUG (MainThread) [custom_components.mqtt_vacuum_camera.sensor] duration in second 79.3 converted to 0:01:19.300000
2024-10-31 17:00:49.006 DEBUG (MainThread) [custom_components.mqtt_vacuum_camera.sensor] duration in second 827.4 converted to 0:13:47.400000
2024-10-31 17:00:49.007 DEBUG (MainThread) [custom_components.mqtt_vacuum_camera.sensor] duration in second 4758 converted to 1:19:18
2024-10-31 17:00:51.715 DEBUG (MainThread) [custom_components.mqtt_vacuum_camera.coordinator] Finished fetching mqtt vacuum camera data in 0.000 seconds (success: True)
2024-10-31 17:00:52.008 DEBUG (MainThread) [custom_components.mqtt_vacuum_camera.sensor] duration in second 79.3 converted to 0:01:19.300000
2024-10-31 17:00:52.008 DEBUG (MainThread) [custom_components.mqtt_vacuum_camera.sensor] duration in second 827.4 converted to 0:13:47.400000
2024-10-31 17:00:52.009 DEBUG (MainThread) [custom_components.mqtt_vacuum_camera.sensor] duration in second 4758 converted to 1:19:18
2024-10-31 17:00:54.714 DEBUG (MainThread) [custom_components.mqtt_vacuum_camera.coordinator] Finished fetching mqtt vacuum camera data in 0.000 seconds (success: True)
2024-10-31 17:00:55.009 DEBUG (MainThread) [custom_components.mqtt_vacuum_camera.sensor] duration in second 79.3 converted to 0:01:19.300000
2024-10-31 17:00:55.009 DEBUG (MainThread) [custom_components.mqtt_vacuum_camera.sensor] duration in second 827.4 converted to 0:13:47.400000
2024-10-31 17:00:55.009 DEBUG (MainThread) [custom_components.mqtt_vacuum_camera.sensor] duration in second 4758 converted to 1:19:18
2024-10-31 17:00:57.715 DEBUG (MainThread) [custom_components.mqtt_vacuum_camera.coordinator] Finished fetching mqtt vacuum camera data in 0.000 seconds (success: True)
2024-10-31 17:00:58.009 DEBUG (MainThread) [custom_components.mqtt_vacuum_camera.sensor] duration in second 79.3 converted to 0:01:19.300000
2024-10-31 17:00:58.009 DEBUG (MainThread) [custom_components.mqtt_vacuum_camera.sensor] duration in second 827.4 converted to 0:13:47.400000
2024-10-31 17:00:58.010 DEBUG (MainThread) [custom_components.mqtt_vacuum_camera.sensor] duration in second 4758 converted to 1:19:18
2024-10-31 17:01:00.716 DEBUG (MainThread) [custom_components.mqtt_vacuum_camera.coordinator] Finished fetching mqtt vacuum camera data in 0.000 seconds (success: True)
2024-10-31 17:01:01.010 DEBUG (MainThread) [custom_components.mqtt_vacuum_camera.sensor] duration in second 79.3 converted to 0:01:19.300000
2024-10-31 17:01:01.010 DEBUG (MainThread) [custom_components.mqtt_vacuum_camera.sensor] duration in second 827.4 converted to 0:13:47.400000
2024-10-31 17:01:01.011 DEBUG (MainThread) [custom_components.mqtt_vacuum_camera.sensor] duration in second 4758 converted to 1:19:18
2024-10-31 17:01:03.715 DEBUG (MainThread) [custom_components.mqtt_vacuum_camera.coordinator] Finished fetching mqtt vacuum camera data in 0.000 seconds (success: True)
2024-10-31 17:01:03.715 WARNING (MainThread) [py.warnings] /usr/src/homeassistant/homeassistant/helpers/update_coordinator.py:168: RuntimeWarning: coroutine 'VacuumSensor._handle_coordinator_update' was never awaited
  update_callback()

2024-10-31 17:01:04.011 DEBUG (MainThread) [custom_components.mqtt_vacuum_camera.sensor] duration in second 79.3 converted to 0:01:19.300000
2024-10-31 17:01:04.012 DEBUG (MainThread) [custom_components.mqtt_vacuum_camera.sensor] duration in second 827.4 converted to 0:13:47.400000
2024-10-31 17:01:04.012 DEBUG (MainThread) [custom_components.mqtt_vacuum_camera.sensor] duration in second 4758 converted to 1:19:18
2024-10-31 17:01:06.715 DEBUG (MainThread) [custom_components.mqtt_vacuum_camera.coordinator] Finished fetching mqtt vacuum camera data in 0.000 seconds (success: True)
2024-10-31 17:01:07.012 DEBUG (MainThread) [custom_components.mqtt_vacuum_camera.sensor] duration in second 79.3 converted to 0:01:19.300000
2024-10-31 17:01:07.012 DEBUG (MainThread) [custom_components.mqtt_vacuum_camera.sensor] duration in second 827.4 converted to 0:13:47.400000
2024-10-31 17:01:07.013 DEBUG (MainThread) [custom_components.mqtt_vacuum_camera.sensor] duration in second 4758 converted to 1:19:18
2024-10-31 17:01:09.714 DEBUG (MainThread) [custom_components.mqtt_vacuum_camera.coordinator] Finished fetching mqtt vacuum camera data in 0.000 seconds (success: True)
2024-10-31 17:01:10.013 DEBUG (MainThread) [custom_components.mqtt_vacuum_camera.sensor] duration in second 79.3 converted to 0:01:19.300000
2024-10-31 17:01:10.013 DEBUG (MainThread) [custom_components.mqtt_vacuum_camera.sensor] duration in second 827.4 converted to 0:13:47.400000
2024-10-31 17:01:10.013 DEBUG (MainThread) [custom_components.mqtt_vacuum_camera.sensor] duration in second 4758 converted to 1:19:18
2024-10-31 17:01:33.714 WARNING (MainThread) [py.warnings] /usr/src/homeassistant/homeassistant/helpers/update_coordinator.py:168: RuntimeWarning: coroutine 'VacuumSensor._handle_coordinator_update' was never awaited
  update_callback()
sca075 commented 1 week ago

@Minims thanks a lot I appreciate your support and hopefully I can solve this issue soon 😉

sca075 commented 1 week ago

@Minims can you please do a test on your instance and let's see if this fix this Warning.. if you have the file editor or VS code installed please edit the sensor.py and remove the line 197. Probably this callback in the async_update is the root cause of the issue.

https://github.com/sca075/mqtt_vacuum_camera/blob/f18ff1a3557fc6c661d24e21a43da9cd1ac2be83/custom_components/mqtt_vacuum_camera/sensor.py#L197

Minims commented 1 week ago

@sca075 it change nothing, i have comment line 197 without success. also tried to comment all block 197-201 and the error still exists.

sca075 commented 1 week ago

Okay strange.. mmmmm I will try to find a solution to this in the next days.. thanks for your help

sca075 commented 1 week ago

@Minims I did try also on Proxmox updating the OS and HA to the later 2024.10.4 and I couldn't reproduce the issue with the last beta of the integration (no modified code). Although I'm aware that the coordinator will need to be refactored. The warning you are facing is probably due to the callback's that I will remove (as I tested this) in the next beta. I'm also studding the homeassistant/helpers/update_coordinator.py and I hope to conclude the troubleshooting within tomorrow. Will keep you posted ;)

sca075 commented 1 week ago

@Minims I think I found a workaround by renaming the _handle_coordinator_update to async_handle_coordinator_update. This avoid to call the helper.. I will work on this issue later on as per I would like to comply to the standards of Home Assistant. I got were is the problem in the implementation will release a new beta later on for you.

sca075 commented 1 week ago

@Minims would you be so kind to test Releases 2024.11.0b1 this should avoid the warning you reported keeping the sensors working. Would be nice when you can give me feedback as soon you have time to test it and also your kind feedback on the added sensors would be really appreciated. Edit: There is also a function that should be interesting for you as per the trims now reset automatically when the map change ;)

Minims commented 1 week ago

@sca075 I have just installed the beta this morning. Everything seems fine. I have no more warning logs in HA.

All sensors are OK and up to date

Capture d’écran 2024-11-06 à 07 49 46

For now i don't see the usage of the additional sensors as i think i already have them in the vacuum attributes and all i need is already displayed in the custom:xiaomi-vacuum-map-card

Maybe it can avoid creating template sensors in some case or help with automation.

Capture d’écran 2024-11-06 à 07 55 17

About map change i need to have a look, for now i'm still using this :

icons:
  - icon: mdi:home-floor-0
    tooltip: Rez de Chaussée
    tap_action:
      action: call-service
      service: vacuum.send_command
      service_data:
        entity_id: vacuum.roger_roborock_s5
        command: load_map
        params:
          name: Rez de Chaussee
  - icon: mdi:box-cutter
    tooltip: Trim
    tap_action:
      action: call-service
      service: mqtt_vacuum_camera.reset_trims
      target:
        entity_id: camera.roborock_s5
      data: {}

Thanks for your job !

sca075 commented 1 week ago

Well I'm really glad, thanks for your inputs. The idea I had when I decided to implement the sensors for Rand256 was exactly what you mentioned. You see.. the official branch of Valetudo provides sensors via MQTT and this is helpful because we do not need to create templates sensors in Home Assistant as Rand256 provides just the attributes of vacuum.

Also as the card already provides the go_to, clean_zone and clean_segment action but those are not registered as actions in Home Assistant.. I would create those vacuum actions from the integration and this should make things a little more easier for you guys setting up the automations and scripts.

The integration is now supporting also the maploader add-on (official Valetudo) and the map_load of Rand256 capabilities in order to reset_trims automatically when the maps change.

It is possible that after all and probably that I'm overthinking this but the aim is to get all in a box and just setup the vacuum to use it in Home Assistant as easy it can be.

Thanks once again for your cooperation @Minims.