scaarup / aula

Fetches information from Aula about your children
GNU General Public License v3.0
51 stars 13 forks source link

Some improvements and cleanup #167

Open bogolob opened 2 months ago

bogolob commented 2 months ago

Hello,

a few weeks ago, I wanted to add my children's EasyIQ ugeplan to my dashboard and came across this integration, but the ugeplan didn't seem to work for me at that point. Long story short, I ended up tinkering with this probably a bit too much :)

This PR is a pretty monster one, but it's mostly for "hello, I'm here!" purposes. I am happy to help split this out into smaller chunks, if you feel that any of these contributions would be welcome.

Improvements and changes:

scaarup commented 2 months ago

This looks awesome! :)

Do you think you can get the latest changes from main's client.py into your PR? This was a rollback of some functionality which broke the integration for a lot of ppl.

scaarup commented 2 months ago

This looks awesome! :)

Do you think you can get the latest changes from main's client.py into your PR? This was a rollback of some functionality which broke the integration for a lot of ppl.

Ah, maybe you already did that..

bogolob commented 2 months ago

I merged those changes by hand, because I already moved quite a bit of code.

scaarup commented 2 months ago

I merged those changes by hand, because I already moved quite a bit of code.

Okay I see. I am just noticing the merge conflict with client.py which could indicate, that your changes are older than the ones on main?