scaffeinate
commented
7 years ago - This is part of a major cleanup/refactoring for better code maintainability
- Refactor sidebars throughout the App
- Create new directory called sidebar/ under shared and remove the existing sidebar partials.
- Split the sidebars majorly into left and right sidebars.
- Add CSS files for sidebars corresponding to the same directory structure as the view files. For eg: views/shared/sidebar/_left.html.erb will have the css in app/assets/stylesheets/shared/sidebar/_left.css.scss.
- Make the DOM structure unified throughout all the sidebars.
- Try to minimize unwanted css and reuse existing classes.
- Move common sidebar css into shared/sidebar/common.css.scss
- Use clean and expressive names for classes and ids of the div elements.
- Remove the user block partial that is used when user profile is visited. Move that into _links.html.erb.
- Add a few methods in SidebarHelper to show/hide elements in Dom. i.e Permissions.
- Render the sidebars from application.html.erb if the user is signed_in. And use yield & content_for so that we don't have to render it in each view.
- Remove the sidebar rendering throughout and render directly from application.html.erb.
- Bunch of dom cleanups went through.
- Fixed the cover_pic since sidebars also have a cover pic. Using separate classes for each of them now.
w0www