search

scaffold-eth / OP-RetroPGF3-Discovery-Voting

Create the voting and discovery process for OP retroactive public goods funding for badgeholders
https://op-retropgf3-discovery-voting.vercel.app
MIT License
14 stars 15 forks source link

Unexpected behavior when using filters #120

Closed ZakGriffith closed 1 year ago

ZakGriffith commented 1 year ago

When using the filters on the project page it appears that the number in each filter is only displaying the count of the projects on that page alone, not all pages. When clicking in, it will also only display the projects on that current page that match the criteria. This is happening in both the grid and list views of projects. These filters should always show the total number of projects that fit the criteria, and push them all into as few pages as possible when clicking, instead of leaving the projects on the page where they were initially displayed.

FiltersPages

KcPele commented 1 year ago

This happens because of the way the projects are being fetched. the pagination happens in the backend, so there will be no way to know all the categories. When a user clicks on next, it fetches it from the backend which is efficient.

ZakGriffith commented 1 year ago

Fixed in #154