scaffold-eth / OP-RetroPGF3-Discovery-Voting

Create the voting and discovery process for OP retroactive public goods funding for badgeholders
https://op-retropgf3-discovery-voting.vercel.app
MIT License
14 stars 14 forks source link

type change rounded icon set #162

Closed KcPele closed 10 months ago

KcPele commented 11 months ago

Description

Icons rounded fixed #159, #158 and fixed some type error Concise description of proposed changes, We recommend using screenshots and videos for better description Screenshot from 2023-10-30 19-43-09 Screenshot from 2023-10-30 19-42-20 Screenshot from 2023-10-30 19-41-56

Additional Information

Related Issues

Closes #{issue number}

Note: If your changes are small and straightforward, you may skip the creation of an issue beforehand and remove this section. However, for medium-to-large changes, it is recommended to have an open issue for discussion and approval prior to submitting a pull request.

Your ENS/address:

vercel[bot] commented 11 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
op-retropgf3-discovery-voting ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 2, 2023 6:51am
ZakGriffith commented 11 months ago

Requested @escottalexander as there are some conflicts here and he has better context than I. Was this from an older version of the branch?

@KcPele

KcPele commented 11 months ago

I have resolved the conflict

KcPele commented 11 months ago

Requested @escottalexander as there are some conflicts here and he has better context than I. Was this from an older version of the branch?

@KcPele

No, it was the latest update

ZakGriffith commented 11 months ago

Gotcha. Feel free to take the look at eh conflicts if you want. Otherwise we can wait for the review.

escottalexander commented 11 months ago

@ZakGriffith @KcPele Can either of you see why the deployment is failing? Perhaps there are still issues. I can't seem to see the output of the deployment.

ZakGriffith commented 11 months ago

It is only failing because of linting errors

image

ZakGriffith commented 11 months ago

In testing this looks good to me! Although we will have to figure out how to move forward getting the icon image to the lists and ballot.

Mergable? @escottalexander