search

scaffold-eth / OP-RetroPGF3-Discovery-Voting

Create the voting and discovery process for OP retroactive public goods funding for badgeholders
https://op-retropgf3-discovery-voting.vercel.app
MIT License
14 stars 15 forks source link

Remove scrollbar from lists #164

Open ZakGriffith opened 1 year ago

ZakGriffith commented 1 year ago

When clicking into a specific list, a scrollbar appears where they have more than a certain number of projects. Let's remove that scrollbar and expand the view to fit all the projects when scrolling the main page. Let's keep the scrollbars in the Edit Distribution and Add To Ballot modals as they are necessary there.

image

blahkheart commented 1 year ago

I'm not sure how ideal the proposed UI/UX would look, the scroll bar only appears when there are a couple of projects in there. Are u suggesting the component keeps growing indefinitely in height depending on the number of projects(which could be a lot) unless the edit modal is opened? I'm not sure it would look great when there are 20-30 projects in there, or we don't expect it to be that much?

ZakGriffith commented 1 year ago

Maybe it's personal preference. I really don't like scrollable areas nested inside other scrollable areas. I would prefer to just scroll through all 30 projects right on the main screen.

KcPele commented 1 year ago

I think this was also in the Figma design we made use off