scaffold-eth / OP-RetroPGF3-Discovery-Voting

Create the voting and discovery process for OP retroactive public goods funding for badgeholders
https://op-retropgf3-discovery-voting.vercel.app
MIT License
14 stars 15 forks source link

Suggested projects blank when looking at a list, made them responsive… #174

Closed electrone901 closed 1 year ago

electrone901 commented 1 year ago

Suggested projects blank when looking at a list, made them responsive with several changes, and removed unused code.

Description

  1. Remove Suggested Projects component and utils not used for this page
  2. Made List details responsive
  3. Change the CustomProjectButton flow to render underneath each other for small devices
  4. Add style for description and impact sections
  5. Test it and it worked.

Additional Information

Your ENS/address: Coderxyz.eth

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
op-retropgf3-discovery-voting ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 9, 2023 1:18am
ZakGriffith commented 1 year ago

I think something changed here for lists with short (or non existing) description/impact. Here is how I am seeing them displayed:
image

Compared to how they were displayed: image

ZakGriffith commented 1 year ago

And those compared to a list with a long description and impact: image

electrone901 commented 1 year ago

Good catch, let me take a look. Thank you for pointing it out.

electrone901 commented 1 year ago

@ZakGriffith I just fixed it, please let me know if I missed anything else.