scaffold-eth / OP-RetroPGF3-Discovery-Voting

Create the voting and discovery process for OP retroactive public goods funding for badgeholders
https://op-retropgf3-discovery-voting.vercel.app
MIT License
14 stars 15 forks source link

List sharing modal update #180

Closed KcPele closed 11 months ago

KcPele commented 12 months ago

Description

List sharing modal updated #157 Concise description of proposed changes, We recommend using screenshots and videos for better description

Additional Information

Related Issues

Closes #{issue number}

Note: If your changes are small and straightforward, you may skip the creation of an issue beforehand and remove this section. However, for medium-to-large changes, it is recommended to have an open issue for discussion and approval prior to submitting a pull request.

Your ENS/address:

vercel[bot] commented 12 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
op-retropgf3-discovery-voting ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 10, 2023 7:58pm
ZakGriffith commented 11 months ago

Good additions with the text sizes and fonts. We also need the buttons updated to the right theme as well. Along the lines of these:

image image

ZakGriffith commented 11 months ago

I am confused on the name of this PR. For future PRs, try to name it based on the updates you are making with some info in the description of all the changes have been made. It will make for quicker merging of the PR if we can quickly tell what it is and what it accomplishes.

KcPele commented 11 months ago

Screenshot from 2023-11-28 09-10-23 Updated

ZakGriffith commented 11 months ago

Nice! I think it would be good to update these buttons as well

image

KcPele commented 11 months ago

Screenshot from 2023-11-29 07-35-43

updated

ZakGriffith commented 11 months ago

After playing around with the buttons here is what I feel is best for them. When viewing your ballot, it should be like this:

image

But with the Submit ballot on the right and the Share as list button on the left. Submit button should be the red background with the darker red mouseover background that is currently found on the cancel button here https://op-retropgf3-discovery-voting.vercel.app/ when you've clicked on My Ballot - Share as List.

The Share as List button should be the black background with the current mouseover color you have it.

This is your current buttons when clicking into the Share as List:

image

These should have the same rounded edges that all the other buttons have, and both be on the right, similar to how it is currently in the My Ballot page. It appears that currently the Cancel button is to the left and the Share List button is to the right.

The color scheme of these buttons should be just like on the My Ballot page where the Share List will be Red with a darker red mouseover, and the Cancel button will be Black with the grey mouseover.

Once more cool thing to add is in the mouseover colors on the Projects and Lists pages. Currently the Projects page "Add To Ballot" buttons don't have a mouseover color, and the "Lists" page has a blue/grey mouse over on the same buttons. Both can be updated with the same mouseover color of dark red mentioned in the above changes while leaving the regular background the OP red.

Note these are all in light mode. Have not yet tested the buttons in dark mode.

Let me know if you have any questions on these updates, and thank you!

KcPele commented 11 months ago

It has been updated as requested

ZakGriffith commented 11 months ago

Buttons colors and shapes are looking great! Once last thing is to put the Share List button on the right and the Cancel button on the left as it was before. They are swapped here:

image

KcPele commented 11 months ago

Done

On Sun, 10 Dec 2023, 20:33 Zak G, @.***> wrote:

Buttons colors and shapes are looking great! Once last thing is to put the Share List button on the right and the Cancel button on the left as it was before. They are swapped here:

image.png (view on web) https://github.com/scaffold-eth/OP-RetroPGF3-Discovery-Voting/assets/12072395/a578d702-8117-4f97-a362-e746bc70fe9d

— Reply to this email directly, view it on GitHub https://github.com/scaffold-eth/OP-RetroPGF3-Discovery-Voting/pull/180#issuecomment-1849059976, or unsubscribe https://github.com/notifications/unsubscribe-auth/APJDTOZNAKYO6JSS6CBJXHTYIYFATAVCNFSM6AAAAAA7TBURPSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNBZGA2TSOJXGY . You are receiving this because you authored the thread.Message ID: @.*** com>