search

scaffold-eth / OP-RetroPGF3-Discovery-Voting

Create the voting and discovery process for OP retroactive public goods funding for badgeholders
https://op-retropgf3-discovery-voting.vercel.app
MIT License
14 stars 15 forks source link

Ballot Review #47

Closed escottalexander closed 1 year ago

escottalexander commented 1 year ago

Ballot page needs to look like designs. image Currently it looks like this: image A UI component does exist that fits the design but it will need to be integrated with any functionality on the current ballot page.

Chirag018 commented 1 year ago

working on this as well!

escottalexander commented 1 year ago

To be clear, The change that needs to be made is that when you click on "View Ballot" it needs to send you to the "My Ballot" view. Currently it sends you to this other "review ballot" but it does not match the designs. Also, there is already an element that looks like the "My Ballot" page that exists. It may lack some of the functionality that the "review ballot" page has though.

escottalexander commented 1 year ago

@Chirag018 You should get latest from the main branch as I just merged in a change that removes the dropdown when the view ballot button is clicked.

ZakGriffith commented 1 year ago

Just tested that aspect and it does work well, nice work! Are you also working on the Ballot page design? Let me know either way and I can either close this issue and create one specifically for that, if leave this one up.

Chirag018 commented 1 year ago

Yeah, working on the ballot page design, there is no issue in having it here/can also pop this out for a new issue and close this one for that as well.

ZakGriffith commented 1 year ago

Closed with #99