search

scaffold-eth / OP-RetroPGF3-Discovery-Voting

Create the voting and discovery process for OP retroactive public goods funding for badgeholders
https://op-retropgf3-discovery-voting.vercel.app
MIT License
14 stars 15 forks source link

Allocation Issues #82

Closed ZakGriffith closed 1 year ago

ZakGriffith commented 1 year ago

There are a handful of bugs that exist when using the project page to allocate votes.

On the pop-up modal when clicking Edit Distribution, then typing a non-number, the field will display NaN. You can delete out the NaN and continue, but if you leave the NaN and click Save, the main allocation bar fills up and displays a NaN. NaN is also displayed on the OP Allocated area of the project page. If you edit distribution again and choose a regular number, then allocated votes returns to normal.

image image

When adding a project to the ballot, then choosing any number (other than 1), the votes will appear in the red allocation bar, but the red Op Allocated section will display a 1. Then clicking back into the Edit Distribution button also shows a 1.

AllocationBug

Similar to the above, the modal for the Add To Ballot and Edit Distribution needs to be locked to only allow the max allocation. In our case that is 100. There is very sporadic behavior if numbers higher than 100 are entered. It should allow a max of (current allocated votes + number entered in modal).

blahkheart commented 1 year ago

I'll work on this

blahkheart commented 1 year ago

Issue closed

ZakGriffith commented 1 year ago

Fixed in #90