chore: adding engines fields in package.json to hint people

scaffold-eth / scaffold-eth-2

Open source forkable Ethereum dev stack

https://scaffoldeth.io

MIT License

1.19k stars 745 forks source link

chore: adding engines fields in package.json to hint people #833

Closed wolfcito closed 2 months ago

wolfcito commented 2 months ago

Description

I have added 'engines' to the package.json file. This practice ensures consistency in the development environment, which is crucial when collaborating with colleagues who may have different versions of Node.js installed

Additional Information

[x] I have read the contributing docs (if this is your first contribution)
[x] This is not a duplicate of any existing pull request

Your ENS/address: wolfcito.eth

carletex commented 2 months ago

@technophile-04 curious to know why it says

instead of 18.17.0? :

damianmarti commented 2 months ago

@wolfcito @technophile-04 I ran yarn install using node v16.17.0 and I didn't get any error (yarn installed all the packages).

Maybe I'm doing something wrong...