scaffold-eth / scaffold-eth-2

Open source forkable Ethereum dev stack
https://scaffoldeth.io
MIT License
1.19k stars 745 forks source link

When you disconnect your burner wallet (with MM closed) it does not show Connect button #843

Closed Pabl0cks closed 2 months ago

Pabl0cks commented 2 months ago

Instead it shows a fake "Wrong network" button, like if you were connected to your MetaMask wallet, but MM is closed, so Switch network does not work, and Disconnect button does not work on the first click.

Only happens first time you access (with MetaMask closed). Then after you correctly disconnect, and connect again with burner, it works fine.

Steps to reproduce:

Check video ![burner-wallet-disconnect-MM-closed](https://github.com/scaffold-eth/scaffold-eth-2/assets/55535804/528c640e-8f74-4cb2-a601-e41b08f6606f)
technophile-04 commented 2 months ago

What do you mean by MM closed or not logged in ? Does it mean :

I tried both, but was not able to reproduce :(, I think I am missing though, here is what I did :

Locking metamask : https://github.com/scaffold-eth/scaffold-eth-2/assets/80153681/fbc7087f-314b-4dd5-af90-264eb998a0da
Disconnecting from website : https://github.com/scaffold-eth/scaffold-eth-2/assets/80153681/778217d7-e060-43f7-b961-4387c4a9f7a2

For me, when switching from burner wallet to metamask the middle phase is always : Click connect button + select metamask from modal

But yeah I might have missed something would love to know, Thanks @Pabl0cks 🙌

Pabl0cks commented 2 months ago

I tried both, but was not able to reproduce :(, I think I am missing though

Sorry Shiv! I should have recorded full screen, I meant with Metamask locked. It happened to me first while testing a Challenge, so went to SE-2 to check if the problem was also there. Anyways, I just tried with computer just switched on, and works well in both Desktop and Laptop.

I've been having cache problems while testing in hardhat since last Metamask update, probably it was a cache issue too 😥

For me, when switching from burner wallet to metamask the middle phase is always : Click connect button + select metamask from modal

Since a few days ago (or last Metamask update probably), if I had Metamask logged in (not locked), when I disconnect from the burner wallet, it would autoconnect to my Metamask wallet. I think that's probably the origin of my problem, but don't know at what point the behavior starts, at some point after testing for a while in hardhat. Will try to monitor, and see if it happens in my laptop also.

I think we can close, I always can reopen if I find a consistent way to reproduce 🙌

Sorry for making you lose time on this @technophile-04 !! ♥

rin-st commented 2 months ago

I've seen something like that in the last few days. I'll let you know if I find a way to 100% reproduce it