search

scaffold-eth / scaffold-eth-2

Open source forkable Ethereum dev stack
https://scaffoldeth.io
MIT License
1.19k stars 745 forks source link

Add default favicon #851

Closed Pabl0cks closed 2 months ago

Pabl0cks commented 2 months ago

Description

Fixes #850

In order to get our default favicon back, we could follow different approaches (let me know if I missed a better approach!):

  1. Add it explicitly to getMetadata.
  2. Add it as optional prop with default value to getMetadata, similar to how we handling unfurl image with imageRelativePath prop.
  3. Moving favicon.png from /public to /app and rename it to icon.png or change the format to favicon.ico. See this

I went for 1 just because it felt simple, and if I had to change the favicon for my app, I'd probably search favicon/icon in the code.

I don't have a strong opinion about this, would love to know what do you think the best practice would be. TYSM ♥

carletex commented 2 months ago

Thanks Pablo!