Migrate to foundry

[technophile-04]

TODOs:

• [X] Port foundry from create-eth and get it working
• [X] Figure out a way to set packages/foundry/.env
  • In future maybe as soon the repo is cloned / installed (maybe postinstall script? or maybe a make file or initial bash script?)
  • Solved: For now we are suggesting cp packages/foundry/.env.example packages/foundry/.env in README
• [X] Clean up scripts in foundry package a bit
  • Solved: For now moved all JS files under scripts-js so that people who are familiar with foundry don't feel weird by seeing js files in script dir.
  • In future, we can move all JS scripts to from foundry package to another package in monorepo (we could use TS too there)
• [X] Update readme (recursive submodules or forge install)
• [X] Configure husky pre-commit hook to do basic foundry lint
  • Runs foundry fmt && prettier as pre-commit step in packages/foundry

Testing steps:

Follow this branch README: https://github.com/scaffold-eth/scaffold-eth-2/tree/foundry-main?tab=readme-ov-file#-scaffold-eth-2

Next todos:

• Update SE-2 docs website
• Create issue from above subpoints
• Get #812 working nicely

[technophile-04]

812 maybe something we could handle in different PR nicely?

[portdeveloper]

Do you think if it could be any better if we could combine the following steps into one?

Could yarn install && forge install --root packages/foundry and cp packages/foundry/.env.example packages/foundry/.env be one step in the install process for people who have just started learning onchain dev?

Maybe it could be one command: yarn setup or yarn buidl

[carletex]

This is great stuff @technophile-04 tysm!! I'll start testing and report back!

[rin-st]

Is it only for me that when I'm using metamask with foundry network, my setGreeting transactions are always pending?

Reset account fixed this

[technophile-04]

Was talking with Carlos and just switched the base branch from main to foundry , thinking that https://github.com/scaffold-eth/scaffold-eth-2/pull/867#discussion_r1651262820 would be really nice if we get it working before we merge all the foundry changes to main branch and then announce the changes also was mentioned in https://github.com/scaffold-eth/scaffold-eth-2/discussions/868.

So for this PR we get this https://github.com/scaffold-eth/scaffold-eth-2/pull/867#discussion_r1651330259 solved merge it to foundry . And then tackle #812 merge it to foundry and after that finally merge foundry => main

[technophile-04]

Just merged the postinstallchanges mentioned in https://github.com/scaffold-eth/scaffold-eth-2/pull/867#discussion_r1651330259 works nicely for me!. cc @Pabl0cks could you test it on windows once w/ without wsl and gitbash also if others could give another try too would be great 🙌

To test first run:

git clone https://github.com/scaffold-eth/scaffold-eth-2.git -b foundry-main scaffold-eth-foundry
cd scaffold-eth-foundry
yarn install && forge install --root packages/foundry

And then the three command yarn chain, yarn deploy, yarn start should work out of the box

[rin-st]

if others could give another try too would be great

for me it also works! 👍

[damianmarti]

Just merged the postinstallchanges mentioned in #867 (comment) works nicely for me!. cc @Pabl0cks could you test it on windows once w/ without wsl and gitbash also if others could give another try too would be great 🙌

To test first run:

git clone https://github.com/scaffold-eth/scaffold-eth-2.git -b foundry-main scaffold-eth-foundry
cd scaffold-eth-foundry
yarn install && yarn install && forge install --root packages/foundry

And then the three command yarn chain, yarn deploy, yarn start should work out of the box

Everything working great on Ubuntu 20.04!!

@technophile-04 Great job!!!

[portdeveloper]

Tried it on a win11 + git bash machine It works great, without any issues! 🚀🚀🚀 Incredible work @technophile-04 !!!

[technophile-04]

Thanks all merging this in foundry branch 🙌