bug: after disconnecting from metamask burner wallet is connected - Githubissues

scaffold-eth / scaffold-eth-2

Open source forkable Ethereum dev stack

https://scaffoldeth.io

MIT License

1.34k stars 837 forks source link

bug: after disconnecting from metamask burner wallet is connected #874

Closed rin-st closed 3 months ago

rin-st commented 3 months ago

Is there an existing issue for this?

[X] I have looked through the existing issues

Which method was used to setup Scaffold-ETH 2 ?

git clone, npx create-eth@latest

Current Behavior

In some cases (see steps to reproduce) after disconnecting from metamask you are connected to burner wallet

https://github.com/scaffold-eth/scaffold-eth-2/assets/25638585/b6847d71-de79-4ef0-8337-4c8663c614e0

Expected Behavior

I'm not connected to any wallet after disconnect

Steps To Reproduce

Connect Metamask
Refresh the page
Disconnect from Metamask

Anything else?

No response

rin-st commented 3 months ago

closing this since it's default behavior :(

Fixing this requires to change default connection of burner-connector to false and changing logic on the client, so I think it's not worth it

cc @carletex @technophile-04