scaffold-eth / scaffold-eth-2

Open source forkable Ethereum dev stack
https://scaffoldeth.io
MIT License
1.42k stars 894 forks source link

Fixes BigInt parsing losing precision in IntegerInput #893

Closed iPaulPro closed 4 months ago

iPaulPro commented 4 months ago

Description

When entering a large number into an IntegerInput component, it is parsed as a JSON string and loses precision.

For example, entering 85604566775863511922702956178915374775782418036268384638508224920020197708340 is parsed into 85604566775863516368369806302131844469805175632226226214501379502487210295296.

This is fixed by first attempting to convert the string value to a BigInt and then returning that value if successful.

Additional Information

Your ENS/address: paulburke.eth

iPaulPro commented 4 months ago

@technophile-04 Great catch and thanks for the incredibly fast merge!