scaffold-eth / scaffold-eth-2

Open source forkable Ethereum dev stack
https://scaffoldeth.io
MIT License
1.41k stars 887 forks source link

revert #875 #905

Closed technophile-04 closed 3 months ago

technophile-04 commented 3 months ago

Description

Reverts the changes from #875.

The reason for #875 was https://github.com/scaffold-eth/create-eth/pull/55#issuecomment-2195411531. Since in create-eth we are no more using prettier from outside to format files and instead using SE-2 instance prettier to format files we don't require this changes anymore.

The reason for reverting this is #901.

To see if this solve #901 :

Copy paste the below in page.tsx insde Home component:

Test snippet : ```ts const [count, setCount] = useState(0); const [name, setName] = useState("shiv"); // should get an eslint error const x = "shiv"; useEffect(() => { setCount(count + 1); console.log(count); setName("shiv"); console.log(name); // should get an eslint warning }, [count]); ```

And hopefully you should get eslint warning / error at mentioned places in the comment.

MattPereira commented 3 months ago

@technophile-04 you are my hero :heart_eyes:

image

rin-st commented 3 months ago

Works great to me! And I agree that this solution is better because it's more stable! Thank you!

technophile-04 commented 3 months ago

Thanks all! Merging this!