search

scaffold-eth / scaffold-eth-2

Open source forkable Ethereum dev stack
https://scaffoldeth.io
MIT License
1.41k stars 887 forks source link

Update dependencies Aug 24 #917

Closed rin-st closed 3 weeks ago

rin-st commented 2 months ago

Description

Tried all the scripts from root package.json and looks like everything works as expected

Additional Information

technophile-04 commented 2 months ago

Lol I am afraid and procrastinating to test this

Probably we could have divided this in to :

  1. updating Wagmi , Viem, Abitype, Rainbowkit versions
  2. Next, react, react-dom all realted package versions
  3. Typescript, eslint, eslint typescript etc versions
  4. Hardhat updagrades
  5. Maybe packages which has major bump a separate PR for each example:
    • usehooks-ts (we had some issues with it previously #707 , #706)
    • uniswap-v2-sdk
    • ...
  6. then rest of remaining small packages?

Maybe sounds a lot of work but this way we make sure there are less unrecognised bugs and if we find a bug its easy to find out to which thing it belongs? because sometimes really wired bug appear like https://github.com/scaffold-eth/scaffold-eth-2/pull/555#issuecomment-1745081772 and hard to debug too

but lol maybe I am being too much cautious

rin-st commented 2 months ago

Probably we could have divided this in to :

You mean create pr for every step, test it, backmerge to create-eth, test it, create new one etc? Looks very slow, but if you want I can create different pr's it's easy.

As an option, you can for example test commit by commit, which is divided into logical blocks. It's not ideal, but I think it's ok. And then only bugfixes prs if needed

rin-st commented 2 months ago

Are you getting this warning on nextjs terminal btw?

<w> [webpack.cache.PackFileCacheStrategy] Caching failed for pack: Error: Unable to snapshot resolve dependencies

Didn't notice it first. This doesn't help.

Upd. getting this warning on main too 🤷‍♂️

rin-st commented 2 months ago

Last react-query version 5.53.1 (3 hours ago) breaks requests with BigInts in response (for example requesting balance of the connected wallet). I need to update structuralSharing or fix serializing or probably they will change this behavior on next versions. I'll update it later

rin-st commented 2 months ago

Last react-query version 5.53.1 (3 hours ago) breaks requests with BigInts in response (for example requesting balance of the connected wallet). I need to update structuralSharing or fix serializing or probably they will change this behavior on next versions. I'll update it later

Throwing error was fixed in 5.53.3 so Balance will work as expected, but without ee3400f warnings still will be on the console

rin-st commented 2 months ago

Lol I am afraid and procrastinating to test this

Probably we could have divided this in to :

  1. updating Wagmi , Viem, Abitype, Rainbowkit versions
  2. Next, react, react-dom all realted package versions
  3. Typescript, eslint, eslint typescript etc versions
  4. Hardhat updagrades

  5. Maybe packages which has major bump a separate PR for each example:

  6. then rest of remaining small packages?

Maybe sounds a lot of work but this way we make sure there are less unrecognised bugs and if we find a bug its easy to find out to which thing it belongs? because sometimes really wired bug appear like #555 (comment) and hard to debug too

but lol maybe I am being too much cautious

Yes, I think it will be easier to do it that way. Starting to make these smaller prs

Also thinking about 7. Up yarn to last version (4.4.1 currently) but need to check stability, speed and so on, not sure it's worth it

rin-st commented 2 months ago

Nextjs still doesn't support eslint v9, so skipping step 3 for now https://github.com/vercel/next.js/issues/64409 , but I think up TS version later. See also https://github.com/scaffold-eth/scaffold-eth-2/pull/905

rin-st commented 3 weeks ago

Resolved, see referenced PRs