search

scaffold-eth / scaffold-eth-2

Open source forkable Ethereum dev stack
https://scaffoldeth.io
MIT License
1.41k stars 887 forks source link

Fix rounding issue when converting to wei #940

Closed lukaw3d closed 2 months ago

lukaw3d commented 2 months ago

Description

Related to https://github.com/scaffold-eth/scaffold-eth-2/pull/894 https://github.com/scaffold-eth/scaffold-eth-2/pull/893

https://abi.ninja/0xde30da39c46104798bb5aa3fe8b9e0e1f348163f/1?methods=transfer
abi ninja_0xde30da39c46104798bb5aa3fe8b9e0e1f348163f_1_methods=transfer abi ninja_0xde30da39c46104798bb5aa3fe8b9e0e1f348163f_1_methods=transfer (1)

Additional Information

Related Issues

Closes #{issue number}

Note: If your changes are small and straightforward, you may skip the creation of an issue beforehand and remove this section. However, for medium-to-large changes, it is recommended to have an open issue for discussion and approval prior to submitting a pull request.

Your ENS/address:

technophile-04 commented 2 months ago

Thanks @lukaw3d for finding and fixing! Also @rin-st for suggestion! Merging this 🙌