We already had an issue with external _blank links https://github.com/scaffold-eth/scaffold-eth-2/pull/909 and now I realized that we have the same problem with hash links (#section). The progress bar will start to load (it shouldn't do anything)
One solution will be to just parse the #links and fix it, but created this PR with another alternative: moving back to next-nprogress-bar which has been updated and supports the App Router nicely. Under the hood it does the same thing that we are doing, but it's handling some stuff a bit better. So it'll be moving custom logic to an external library.
Happy to close this, just wanted to hear your take on it.
When we migrated to the App Router https://github.com/scaffold-eth/scaffold-eth-2/pull/535 we switched from https://www.npmjs.com/package/next-nprogress-bar to https://www.npmjs.com/package/nprogress + creating a custom integration with the App Router.
We already had an issue with external
_blanklinks https://github.com/scaffold-eth/scaffold-eth-2/pull/909 and now I realized that we have the same problem with hash links (#section). The progress bar will start to load (it shouldn't do anything)One solution will be to just parse the #links and fix it, but created this PR with another alternative: moving back to
next-nprogress-barwhich has been updated and supports the App Router nicely. Under the hood it does the same thing that we are doing, but it's handling some stuff a bit better. So it'll be moving custom logic to an external library.Happy to close this, just wanted to hear your take on it.
Thanks!!