search

scaffold-eth / scaffold-eth-2

Open source forkable Ethereum dev stack
https://scaffoldeth.io
MIT License
1.41k stars 887 forks source link

Use mainnet RPC for default forking URL #964

Closed moltam89 closed 1 month ago

moltam89 commented 1 month ago

Hey guys,

with this change we can use yarn fork out of the box.

Cheers, Tamas

technophile-04 commented 1 month ago

Hey thanks @moltam89! The reason why we didn't do this is because https://github.com/scaffold-eth/scaffold-eth-2/pull/955#discussion_r1794469370

moltam89 commented 1 month ago

Thanks @technophile-04 !

I noticed today that yarn fork works with foundry and I guessed that we want this for hardhat as well.

But probably it is the other way and foundry should not use https://cloudflare-eth.com for forking either.

technophile-04 commented 1 month ago

I noticed today that yarn fork works with foundry and I guessed that we want this for hardhat as well.

But probably it is the other way and foundry should not use https://cloudflare-eth.com/ for forking either.

Ohh yes we could probably remove it foundry too. Because it will also block the frontend if users fork make a lot of request during fork.

Do you want to create a PR removing it from foundry?