scaffold-eth / scaffold-eth-2

Open source forkable Ethereum dev stack
https://scaffoldeth.io
MIT License
1.41k stars 887 forks source link

Add shell script for prod deployments + modify Makefile accordingly #972

Open portdeveloper opened 1 month ago

portdeveloper commented 1 month ago

Hello!

This PR:

-> adds a shell script to give the user a menu for selecting a keystore when deploying to any network other than the local anvil node -> modifies the makefile to pass in the RPC_URL from the foundry.toml file to the shell script -> works in linux and macos, since foundry does not work on windows natively, windows is ignored. So we should test this on: linux + wsl + macos -> removes the need to modify the .env file when changing keystores to use

Possible To-Do:

-> ‘—keystore’ flag (thx to Shiv for the suggestion) I have some working code on this, but it accepts variables like this: yarn deploy --network sepolia my-keystore instead of yarn deploy --network sepolia --keystore my-keystore We can also introduce a new script as I couldn't find how to achieve this without doing so. Tried passing in another flag in the package.json, but did not work.