scaffold-eth / scaffold-eth-2

Open source forkable Ethereum dev stack
https://scaffoldeth.io
MIT License
1.42k stars 894 forks source link

Fix debug page contracts view #975

Closed rin-st closed 4 weeks ago

rin-st commented 1 month ago

Description

Fixes https://github.com/scaffold-eth/scaffold-eth-2/issues/939

One of the possible (and simple) solutions is to use sessionStorage instead of localStorage. As I understand it doesn't change anything except one case: User worked with debug page where he chose some non-first contract. User closes browser tab with his debug page and open debug page in another browser tab. With localStorage, last chosen contract will be selected. With sessionStorage first contract will be selected. I believe it's not a problem at all

Additionally, using sessionStorage adds possibility to view different contracts of debug page in different browser tabs


What I also tried to do:

carletex commented 1 month ago

With sessionStorage first contract will be selected. I believe it's not a problem at all

Agree.

The main reason we have this functionality is to avoid "losing the contract focus" if you refresh the page. And session storage does the trick too