search

scaffold-eth / se-2-challenges

SpeedRunEthereum challenges (Powered by Scaffold-ETH 2)
https://speedrunethereum.com
MIT License
72 stars 138 forks source link

Chall5: Make it autograder ready #143

Closed technophile-04 closed 6 months ago

technophile-04 commented 6 months ago

Description:

Screenshot 2024-02-27 at 4 56 13 PM

Does not break anything both locally while running test and on autograder also works nicely 🙌

carletex commented 6 months ago

Wondering if we should change the ID (9 => 5)

We'd need to do it in the Autograder + the SRE repo.

It's an internal thing... but I might sleep better haha

What do you think?

technophile-04 commented 6 months ago

Wondering if we should change the ID (9 => 5) We'd need to do it in the Autograder + the SRE repo. It's an internal thing... but I might sleep better haha What do you think?

+1 for change the ID (9 => 5) and +100 for Carlo's better sleep 😂, We should def do it if it doesn't have lot of side effects 🙌

carletex commented 6 months ago

See

https://github.com/BuidlGuidl/SpeedRunEthereum/pull/198 https://github.com/austintgriffith/speedrun-grader/pull/9/commits/bb459dffcc2129b28988c0cfd4e0811bd1e40886