search

scaffold-eth / se-2-challenges

SpeedRunEthereum challenges (Powered by Scaffold-ETH 2)
https://speedrunethereum.com
MIT License
72 stars 138 forks source link

Removed ownable from contract #146

Closed miki-saarna closed 6 months ago

miki-saarna commented 6 months ago

Within Checkpoint 2: ⚖️ Vendor 🤖, the instruction Edit Vendor.sol to inherit Ownable assumes that the Vendor contract isn't already Ownable. Therefore, the Vender contract should not inherit the Ownable contract by default. Instead, the user should update the contract to inherit the Ownable contract when the instruction Edit Vendor.sol to inherit Ownable is reached.

rin-st commented 6 months ago

Thanks for your pr @miki-saarna , nice catch! Please check my comment

rin-st commented 6 months ago

Updated uncomment message as mentioned here https://github.com/scaffold-eth/se-2-challenges/pull/146#discussion_r1510291060

Merging this, thank you again!