search

scaffold-eth / se-2-challenges

SpeedRunEthereum challenges (Powered by Scaffold-ETH 2)
https://speedrunethereum.com
MIT License
72 stars 138 forks source link

Challenge 5 wagmi 2 backmerge #178

Closed rin-st closed 3 months ago

rin-st commented 3 months ago

note: currently I'm not using burner-connector (but added it to package.json) since in this challenge we need a new burner account in every tab. So I use mostly copypasted code with sessionStorage instead of localStorage. Hopefully we'll add a possibility to use sessionStorage in next versions of burner-connector.

note 2: sorry again for commits list, it looks I need to merge pr without squash

rin-st commented 3 months ago

Great findings @Pabl0cks !

I refactored Streamer page and divided it into Guru and Rube components as I wanted for months 😄 . Now it's much easier to understand the logic. I found a bug which caused errors and hopefully 1-3 are fixed. Regarding 4 it didn't work from the start. I think we need to create an issue for it?

Also I changed Readme.md (see last commit). If you think wording is not very good please feel free to update it. Thanks!

Pabl0cks commented 3 months ago

I refactored Streamer page and divided it into Guru and Rube components as I wanted for months 😄 . Now it's much easier to understand the logic. I found a bug which caused errors and hopefully 1-3 are fixed. Regarding 4 it didn't work from the start. I think we need to create an issue for it?

Also I changed Readme.md (see last commit). If you think wording is not very good please feel free to update it.

Awesome job! Now is working like a charm, even the 4th point is working fine to me now 🙌

Just added a small comment to check.

rin-st commented 3 months ago

Created an issue for it, will fix it a bit later https://github.com/scaffold-eth/se-2-challenges/issues/180