search

scaffold-eth / se-2-docs

Documentation site for Scaffold-ETH 2
https://docs.scaffoldeth.io
MIT License
13 stars 26 forks source link

Add externalContracts explanations on hooks doc #36

Closed Pabl0cks closed 11 months ago

Pabl0cks commented 12 months ago

I've just added a initial explanation on how to add external contracts to externalContracts.ts file, in order to use Scaffold ETH-2 hooks on them. May need a first tech review from @technophile-04 the explanations are correct.

Was not sure about adding a full mock test example at the end of the doc, since it helped to me I've finally added it, but we can ✂ if you see not necessary.

Closes #35

vercel[bot] commented 12 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
scaffold-eth-2-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 12, 2023 10:38pm
carletex commented 12 months ago

Great stuff @Pabl0cks , thanks!

Left some comments with my views

Pabl0cks commented 11 months ago

Thanks for the review @carletex, love all the suggestions! Just pushed them 🙌♥

Indeed the mock example was a bit too much, even took a while to unfold on my computer haha

Maybe if we see people needing help with their externalContracts.ts file we can just share them the mock example with a gist. But probably people using external contracts won't have problems with abi format.

carletex commented 11 months ago

Thanks @Pabl0cks !!