Closed gregorycrane closed 8 months ago
@gregorycrane: Thanks for sharing.
https://www.homermultitext.org/facsimiles/venetus-a-2020/pages/urn_cite2_hmt_msA-v1_12r.html would correspond our view at https://beyond-translation.perseus.org/reader/urn:cts:greekLit:tlg0012.tlg001.msA-folios:12r.1.1-12r.1.25?mode=folio.
@pletcher and I just had a call walking through some of the building blocks within Beyond Translation (specifically the backend where we're loading in some of the CITE data from the CEX files and how we're querying that data for display on the frontend).
To start with, he's going to explore being able to select a text part reference in the viewer and to see the bounding box drawn within OpenSeadragon; there are a few more things we'll need to get sorted out with the scholia data to integrate the regions of interest with the scholia that we'll take on in a later pass.
@pletcher and @gregorycrane: I had a meeting last week with Cliff Anderson (who works at Jean and Alexander Heard Library at Vanderbilt University), and he was demonstrating some ROI / IIIF functionality that Wikimedia Commons and Wikidata expose.
The Wikidata page for coronation of Napoleon I refers to a painting (Jacques-Louis David, The Coronation of Napoleon) that has been tagged with ROIs for the people in the painting.
https://wd-image-positions.toolforge.org/iiif_region/pct:52.6,55,13.4,33.3 has a viewer that draws the ROIs, and the ROIs then link to Wikidata pages (e.g. Napoleon).
I'm not suggesting we incorporate Wikidata or their viewer, but just thought it was another example of interactivity between the image and structured content.
@pletcher and I just talked through the next round of things on a call:
ImageROI
GraphQL field (via #112)If / when all that is working, we can experiment more with bi-directional selection (click a scholia entry to highlight the form), and then other thorny issues (distinguishing between "line" selections and "form" selections, etc)
(@jacobwegner would like to also revisit the "commentaries" widget / display mode for scholia...so that selecting a form or scholia entry on the folio viewer would interact with the sidebar widget
Hi @jacobwegner, sorry for taking so long to get back to this. I'm working on the scholia highlights, and I noticed that textAnnotation ROI fields are available at the hosted GraphQL instance, but I can't seem to find the commit where that change happened to test it locally.
I just get an empty array in the roi
field that I added to ScholiaWidget's gql query.
Do I need to re-ingest some data, or should I be working off of a different branch?
Thanks!
(@jacobwegner and @pletcher to sync up on the closed PR; bring new styles forward)
@pletcher Would you mind linking to whatever branches your latest is on into this issue, and I can resurrect the PRs / preview instance?
I can then also look at the data mapping task and circle back to you.
Thanks!
Hi @jacobwegner, sure thing, and sorry for the delay!
scaife-viewer/frontend: https://github.com/pletcher/scaife-viewer-frontend/tree/feature/regions-of-interest
scaife-viewer/backend: https://github.com/pletcher/scaife-viewer-backend/tree/feature/regions-of-interest
I think that should be everything.
Thanks!
Comparing 248v
https://www.homermultitext.org/facsimiles/venetus-a-2020/pages/urn_cite2_hmt_msA-v1_248v.html
cc @gregorycrane
Getting very close to these changes being merged.
A few final TODOS:
[x] Figure out if we can get a data update done easily (https://github.com/scaife-viewer/beyond-translation-site/issues/100#issuecomment-1697481630), https://github.com/scaife-viewer/beyond-translation-site/issues/167#issuecomment-1687205536
[ ] Distinguish between "Scholia" and "Commentary/Textual Notes" so the widgets don't duplicate content
(this is already happening on prod, so we could skiip)
[x] Fix regression on "image only" mode:
@gregorycrane latest data and code have been deployed here:
I still have a couple of small housekeeping tasks, but I think at this point I'd like you to take a look and see if what we have done is "good enough".
I discovered we had been missing several folios:
294v-310r
Last bits of feedback from @gregorycrane:
v2
issue (e.g., scroll into view, filtering by scholia kind, etc --> https://github.com/scaife-viewer/beyond-translation-site/issues/177)Have to step away for the day, but I did find a few OpenSeaDragon settings to fix the zoom issues, and I've been able to replicate some of the border styling from HMT:
Scaife Viewer:
HMT:
Scholia entries in the sidebar now show the same colors as the viewer:
and we have a legend that shows what type of scholia correspond to each color:
@gregorycrane I have made all of the changes we discussed on Tuesday. I'm going to move on to UD stuff next week, but I am still waiting a final look from you before we merge / deploy to production:
@gregorycrane The latest changes to the Legend and showing Scholia kind on hover have been deployed to the preview instance:
I'm going to cut a production release and will close this issue when that has been completed.
@gregorycrane This has been deployed in the v2023-11-07-001 release:
https://www.homermultitext.org/facsimiles/venetus-a-2020/pages/urn_cite2_hmt_msA-v1_248v.html -- this is not using IIIF and is a one-off, but it nicely shows the information.